Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2271423002: Update decoded frame counts when the sink isn't running. (Closed)

Created:
4 years, 4 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update decoded frame counts when the sink isn't running. Fixes issues where this count is not updated until playback begins. BUG=640046 TEST=updated unit test expectations. Committed: https://crrev.com/794b1f43e762214f89ecc2dbe3f063cde9354ff4 Cr-Commit-Position: refs/heads/master@{#414547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 6 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
DaleCurtis
4 years, 4 months ago (2016-08-24 22:19:22 UTC) #3
chcunningham
lgtm
4 years, 4 months ago (2016-08-24 23:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271423002/1
4 years, 4 months ago (2016-08-24 23:03:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280477)
4 years, 4 months ago (2016-08-25 00:38:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271423002/1
4 years, 4 months ago (2016-08-25 00:54:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280585)
4 years, 4 months ago (2016-08-25 04:55:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271423002/1
4 years, 3 months ago (2016-08-25 17:46:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 21:56:24 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 21:58:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/794b1f43e762214f89ecc2dbe3f063cde9354ff4
Cr-Commit-Position: refs/heads/master@{#414547}

Powered by Google App Engine
This is Rietveld 408576698