chrome/android/java/res/layout/item_chooser_dialog_row.xml - Issue 2271413002: bluetooth: Implement RSSI indicator on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/item_chooser_dialog_row.xml

Issue 2271413002: bluetooth: Implement RSSI indicator on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-impl-rssi-tx-power

Patch Set: Clean up Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/ic_signal_cellular_4_bar_white_24dp.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/item_chooser_dialog_row.xml

diff --git a/chrome/android/java/res/layout/item_chooser_dialog_row.xml b/chrome/android/java/res/layout/item_chooser_dialog_row.xml

index f36586a3aeef43f02463257c0e7302dfeb85147c..862dbe21391383b2a951d7fe34df2e3a9a3a48ca 100644

--- a/chrome/android/java/res/layout/item_chooser_dialog_row.xml

+++ b/chrome/android/java/res/layout/item_chooser_dialog_row.xml

@@ -3,11 +3,32 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-<TextView xmlns:android="http://schemas.android.com/apk/res/android"

+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

android:layout_width="match_parent"

android:layout_height="48dp"

android:paddingStart="16dp"

- android:paddingEnd="16dp"

- android:ellipsize="end"

- android:gravity="center_vertical"

- android:singleLine="true" />

+ android:paddingEnd="16dp">

+ <LinearLayout

+ android:id="@+id/imageContainer"

+ android:layout_width="56dp"

+ android:layout_height="match_parent"

+ android:gravity="center_vertical"

+ android:visibility="gone">

+

+ <ImageView

+ android:id="@+id/icon"

+ android:contentDescription="@null"

juncai 2016/09/12 20:05:49 wondering why the character '»' is here?

ortuno 2016/09/13 03:00:45 Argh, my editor accidentally added a tab here. Don

+ android:layout_width="24dp"

+ android:layout_height="24dp"/>

+ </LinearLayout>

+ <TextView

+ android:id="@+id/description"

+ android:layout_width="wrap_content"

+ android:layout_height="match_parent"

+ android:layout_alignWithParentIfMissing="true"

+ android:layout_alignParentEnd="true"

+ android:layout_toEndOf="@+id/imageContainer"

+ android:ellipsize="end"

+ android:gravity="center_vertical"

+ android:singleLine="true"/>

+</RelativeLayout>