bluetooth: Implement RSSI indicator on android

chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.Manifest;
 import android.app.Activity;
 import android.content.BroadcastReceiver;
 import android.content.Context;
@@ skipping 28 matching lines @@
     // notifyDiscoveryState().
     static final int DISCOVERY_FAILED_TO_START = 0;
     static final int DISCOVERING = 1;
     static final int DISCOVERY_IDLE = 2;
 
     // Values passed to nativeOnDialogFinished:eventType, and only used in the native function.
     static final int DIALOG_FINISHED_DENIED_PERMISSION = 0;
     static final int DIALOG_FINISHED_CANCELLED = 1;
     static final int DIALOG_FINISHED_SELECTED = 2;
 
+    private static final int SIGNAL_STRENGTH_ICONS[][] =
+            new int[][] {{R.drawable.ic_signal_cellular_0_bar_grey600_24dp,
+                                 R.drawable.ic_signal_cellular_0_bar_white_24dp},
+                    {R.drawable.ic_signal_cellular_1_bar_grey600_24dp,
+                            R.drawable.ic_signal_cellular_1_bar_white_24dp},
+                    {R.drawable.ic_signal_cellular_2_bar_grey600_24dp,
+                            R.drawable.ic_signal_cellular_2_bar_white_24dp},
+                    {R.drawable.ic_signal_cellular_3_bar_grey600_24dp,
+                            R.drawable.ic_signal_cellular_3_bar_white_24dp},
+                    {R.drawable.ic_signal_cellular_4_bar_grey600_24dp,
+                            R.drawable.ic_signal_cellular_4_bar_white_24dp}};
+
     // The window that owns this dialog.
     final WindowAndroid mWindowAndroid;
 
     // Always equal to mWindowAndroid.getActivity().get(), but stored separately to make sure it's
     // not GC'ed.
     final Activity mActivity;
 
     // The dialog to show to let the user pick a device.
     ItemChooserDialog mItemChooserDialog;
 
@@ skipping 271 matching lines @@
             return null;
         }
         BluetoothChooserDialog dialog = new BluetoothChooserDialog(
                 windowAndroid, origin, securityLevel, nativeBluetoothChooserDialogPtr);
         dialog.show();
         return dialog;
     }
 
     @VisibleForTesting
     @CalledByNative
-    void addOrUpdateDevice(String deviceId, String deviceName) {
-        mItemChooserDialog.addOrUpdateItem(
-                new ItemChooserDialog.ItemChooserRow(deviceId, deviceName));
+    void addOrUpdateDevice(String deviceId, String deviceName, int signalStrengthLevel) {
+        ItemChooserDialog.ItemChooserRowIcon signalStrengthLevelIcon = null;
+        assert 0 <= signalStrengthLevel && signalStrengthLevel <= 4;

[juncai, 2016/09/12 20:05:49]

I think this assert needs to be moved inside the following if statement.
Otherwise when |signalStrengthLevel| is actually -1, the assert fails.

I saw the test code tests when |signalStrengthLevel| is -1, just wondering why
the test code didn't fail at the assert?

Also instead of using the hard code number 4, maybe calculate the size of
|SIGNAL_STRENGTH_ICONS|.

[ortuno, 2016/09/13 03:00:45]

Made the first condition -1.
It's probably because asserts are not enabled on build bots.
Done.

+        if (signalStrengthLevel != -1) {
+            int iconPair[] = SIGNAL_STRENGTH_ICONS[signalStrengthLevel];
+            signalStrengthLevelIcon = new ItemChooserDialog.ItemChooserRowIcon(
+                    iconPair[0], iconPair[1], mActivity.getResources().getQuantityString(
+                                                      R.plurals.signal_strength_level_n_bars,
+                                                      signalStrengthLevel, signalStrengthLevel));
+        }
+        mItemChooserDialog.addOrUpdateItem(new ItemChooserDialog.ItemChooserRow(
+                deviceId, deviceName, signalStrengthLevelIcon));
     }
 
     @VisibleForTesting
     @CalledByNative
     void closeDialog() {
         mNativeBluetoothChooserDialogPtr = 0;
         mItemChooserDialog.dismiss();
     }
 
     @VisibleForTesting
@@ skipping 50 matching lines @@
     @VisibleForTesting
     native void nativeRestartSearch(long nativeBluetoothChooserAndroid);
     // Help links.
     @VisibleForTesting
     native void nativeShowBluetoothOverviewLink(long nativeBluetoothChooserAndroid);
     @VisibleForTesting
     native void nativeShowBluetoothAdapterOffLink(long nativeBluetoothChooserAndroid);
     @VisibleForTesting
     native void nativeShowNeedLocationPermissionLink(long nativeBluetoothChooserAndroid);
 }