chrome/android/java/res/layout/item_chooser_dialog_row_with_icon.xml - Issue 2271413002: bluetooth: Implement RSSI indicator on android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/item_chooser_dialog_row_with_icon.xml

Issue 2271413002: bluetooth: Implement RSSI indicator on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-impl-rssi-tx-power

Patch Set: Clean up Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/ic_signal_cellular_4_bar_white_48dp.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	juncai 2016/08/26 19:37:48 Since we already have an item_chooser_dialog_row.x Since we already have an item_chooser_dialog_row.xml: https://cs.chromium.org/chromium/src/chrome/android/java/res/layout/item_choo... I am wondering if that one can be reused by adding the ImageView to it instead of creating a item_chooser_dialog_row_with_icon.xml? I noticed that there is RelativeLayout: https://cs.chromium.org/chromium/src/chrome/android/java/res/layout/web_notif... And can set element.setVisibility(View.GONE); to hide a view, and android:layout_alignWithParentIfMissing to make a view to take the missing view's space. If so, when the "connected"/"paired" status need to be added to the row, it will be easier. ortuno 2016/09/12 05:11:27 Ah good idea. Done. Show quoted text On 2016/08/26 at 19:37:48, juncai wrote: > Since we already have an item_chooser_dialog_row.xml: > https://cs.chromium.org/chromium/src/chrome/android/java/res/layout/item_choo... > I am wondering if that one can be reused by adding the ImageView to it instead of creating a item_chooser_dialog_row_with_icon.xml? I noticed that there is RelativeLayout: > https://cs.chromium.org/chromium/src/chrome/android/java/res/layout/web_notif... > > And can set element.setVisibility(View.GONE); to hide a view, and android:layout_alignWithParentIfMissing to make a view to take the missing view's space. > > If so, when the "connected"/"paired" status need to be added to the row, it will be easier. Ah good idea. Done.
	7 android:orientation="horizontal"

	8 android:layout_width="match_parent"

	9 android:layout_height="48dp"

	10 android:paddingStart="16dp"

	11 android:paddingEnd="16dp"

	12 android:gravity="center_vertical">

	13 <LinearLayout

	14 android:id="@+id/imageContainer"

	15 android:layout_width="56dp"

	16 android:layout_height="match_parent"

	17 android:gravity="center_vertical">

	18 <ImageView

	19 android:id="@+id/icon"

	20 android:layout_width="24dp"

	21 android:layout_height="24dp"/>

	22 </LinearLayout>

	23 <TextView

	24 android:id="@+id/description"

	25 android:layout_width="fill_parent"

	26 android:layout_height="match_parent"

	27 android:ellipsize="end"

	28 android:gravity="center_vertical"

	29 android:singleLine="true"/>

	30 </LinearLayout>

OLD	NEW