bluetooth: Implement RSSI indicator on android

chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.Manifest;
 import android.app.Activity;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
+import android.content.res.Resources;
+import android.graphics.drawable.Drawable;
+import android.graphics.drawable.LevelListDrawable;
+import android.graphics.drawable.StateListDrawable;
 import android.location.LocationManager;
+import android.support.graphics.drawable.VectorDrawableCompat;
 import android.text.SpannableString;
 import android.text.TextUtils;
 import android.view.View;
 
+import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizer;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.components.location.LocationUtils;
 import org.chromium.ui.base.WindowAndroid;
 import org.chromium.ui.text.NoUnderlineClickableSpan;
 import org.chromium.ui.text.SpanApplier;
 import org.chromium.ui.text.SpanApplier.SpanInfo;
@@ skipping 28 matching lines @@
     // The dialog to show to let the user pick a device.
     ItemChooserDialog mItemChooserDialog;
 
     // The origin for the site wanting to pair with the bluetooth devices.
     String mOrigin;
 
     // The security level of the connection to the site wanting to pair with the
     // bluetooth devices. For valid values see SecurityStateModel::SecurityLevel.
     int mSecurityLevel;
 
+    LevelListDrawable strengthSignalIcons;
+
     // A pointer back to the native part of the implementation for this dialog.
     long mNativeBluetoothChooserDialogPtr;
 
     // Used to keep track of when the Mode Changed Receiver is registered.
     boolean mIsLocationModeChangedReceiverRegistered = false;
 
     @VisibleForTesting
     final BroadcastReceiver mLocationModeBroadcastReceiver = new BroadcastReceiver() {
         @Override
         public void onReceive(Context context, Intent intent) {
@@ skipping 23 matching lines @@
      */
     @VisibleForTesting
     BluetoothChooserDialog(WindowAndroid windowAndroid, String origin, int securityLevel,
             long nativeBluetoothChooserDialogPtr) {
         mWindowAndroid = windowAndroid;
         mActivity = windowAndroid.getActivity().get();
         assert mActivity != null;
         mOrigin = origin;
         mSecurityLevel = securityLevel;
         mNativeBluetoothChooserDialogPtr = nativeBluetoothChooserDialogPtr;
+        Resources resources = mActivity.getResources();
+
+        StateListDrawable level0 = new StateListDrawable();
+        level0.addState(new int[] {-android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_0_bar_grey, null /* theme */));

[Ian Wen, 2016/10/14 01:39:51]

Why not simply use mActivity.getTheme() here? Or if you don't care about theme I
would remove the comment as well.

+        level0.addState(new int[] {android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_0_bar_white, null /* theme */));
+
+        StateListDrawable level1 = new StateListDrawable();
+        level1.addState(new int[] {-android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_1_bar_grey, null /* theme */));
+        level1.addState(new int[] {android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_1_bar_white, null /* theme */));
+
+        StateListDrawable level2 = new StateListDrawable();
+        level2.addState(new int[] {-android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_2_bar_grey, null /* theme */));
+        level2.addState(new int[] {android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_2_bar_white, null /* theme */));
+
+        StateListDrawable level3 = new StateListDrawable();
+        level3.addState(new int[] {-android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_3_bar_grey, null /* theme */));
+        level3.addState(new int[] {android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_3_bar_white, null /* theme */));
+
+        StateListDrawable level4 = new StateListDrawable();
+        level4.addState(new int[] {-android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_4_bar_grey, null /* theme */));
+        level4.addState(new int[] {android.R.attr.state_selected},
+                VectorDrawableCompat.create(
+                        resources, R.drawable.ic_signal_cellular_4_bar_white, null /* theme */));
+
+        strengthSignalIcons = new LevelListDrawable();
+        strengthSignalIcons.addLevel(0, 0, level0);
+        strengthSignalIcons.addLevel(1, 1, level1);
+        strengthSignalIcons.addLevel(2, 2, level2);
+        strengthSignalIcons.addLevel(3, 3, level3);
+        strengthSignalIcons.addLevel(4, 4, level4);
     }
 
     /**
      * Show the BluetoothChooserDialog.
      */
     @VisibleForTesting
     void show() {
         // Emphasize the origin.
         Profile profile = Profile.getLastUsedProfile();
         SpannableString origin = new SpannableString(mOrigin);
@@ skipping 30 matching lines @@
         SpannableString statusIdleSomeFound = SpanApplier.applySpans(
                 mActivity.getString(R.string.bluetooth_not_seeing_it_idle_some_found),
                 new SpanInfo("<link1>", "</link1>",
                         new BluetoothClickableSpan(LinkType.EXPLAIN_BLUETOOTH, mActivity)),
                 new SpanInfo("<link2>", "</link2>",
                         new BluetoothClickableSpan(LinkType.RESTART_SEARCH, mActivity)));
 
         ItemChooserDialog.ItemChooserLabels labels =
                 new ItemChooserDialog.ItemChooserLabels(title, searching, noneFound, statusActive,
                         statusIdleNoneFound, statusIdleSomeFound, positiveButton);
-        mItemChooserDialog = new ItemChooserDialog(mActivity, this, labels);
+        mItemChooserDialog = new ItemChooserDialog(mActivity, this, labels, true /* usingIcon */);
 
         mActivity.registerReceiver(mLocationModeBroadcastReceiver,
                 new IntentFilter(LocationManager.MODE_CHANGED_ACTION));
         mIsLocationModeChangedReceiverRegistered = true;
     }
 
     // Called to report the dialog's results back to native code.
     private void finishDialog(int resultCode, String id) {
         if (mIsLocationModeChangedReceiverRegistered) {
             mActivity.unregisterReceiver(mLocationModeBroadcastReceiver);
@@ skipping 160 matching lines @@
             return null;
         }
         BluetoothChooserDialog dialog = new BluetoothChooserDialog(
                 windowAndroid, origin, securityLevel, nativeBluetoothChooserDialogPtr);
         dialog.show();
         return dialog;
     }
 
     @VisibleForTesting
     @CalledByNative
-    void addOrUpdateDevice(String deviceId, String deviceName) {
+    void addOrUpdateDevice(String deviceId, String deviceName, int signalStrengthLevel) {
+        assert - 1 <= signalStrengthLevel && signalStrengthLevel <= 4;
+        ItemChooserDialog.ItemChooserRow row = mItemChooserDialog.getItemChooserRow(deviceId);
+        Drawable icon = null;
+        String iconDescription = null;
+        boolean didUpdateOldDrawable = false;
+        if (signalStrengthLevel != -1) {
+            if (row == null) {
+                icon = strengthSignalIcons.getConstantState().newDrawable();
+            } else {
+                icon = row.getIcon();
+            }
+            if (icon.setLevel(signalStrengthLevel)) {
+              icon.invalidateSelf();
+            }
+            iconDescription = mActivity.getResources().getQuantityString(
+                    R.plurals.signal_strength_level_n_bars, signalStrengthLevel,
+                    signalStrengthLevel);
+            didUpdateOldDrawable = true;
+        }
         mItemChooserDialog.addOrUpdateItem(
-                new ItemChooserDialog.ItemChooserRow(deviceId, deviceName));
+            new ItemChooserDialog.ItemChooserRow(deviceId, deviceName, icon, iconDescription),

[Ian Wen, 2016/10/14 01:39:51]

IIRC this method will be called more than 10 times per second, right?

If so I would favor getting rid of the "new ItemChooserDialog...." statement
because that's too much GC burden to jvm. I see you already have an
ItemChooserRow object, how about we only modify it inplace, and not create new
objects?

+            didUpdateOldDrawable);
     }
 
     @VisibleForTesting
     @CalledByNative
     void closeDialog() {
         mNativeBluetoothChooserDialogPtr = 0;
         mItemChooserDialog.dismiss();
     }
 
     @VisibleForTesting
@@ skipping 50 matching lines @@
     @VisibleForTesting
     native void nativeRestartSearch(long nativeBluetoothChooserAndroid);
     // Help links.
     @VisibleForTesting
     native void nativeShowBluetoothOverviewLink(long nativeBluetoothChooserAndroid);
     @VisibleForTesting
     native void nativeShowBluetoothAdapterOffLink(long nativeBluetoothChooserAndroid);
     @VisibleForTesting
     native void nativeShowNeedLocationPermissionLink(long nativeBluetoothChooserAndroid);
 }