bluetooth: Implement RSSI indicator on android

chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Dialog;
+import android.content.res.Resources;
+import android.support.graphics.drawable.VectorDrawableCompat;
 import android.test.suitebuilder.annotation.LargeTest;
 import android.text.SpannableString;
 import android.view.View;
 import android.widget.Button;
 import android.widget.ListView;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.test.util.RetryOnFailure;
 import org.chromium.chrome.R;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.content.browser.test.util.TouchCommon;
 import org.chromium.ui.widget.TextViewWithClickableSpans;
 
 import java.util.concurrent.Callable;
 
 /**
  * Tests for the ItemChooserDialog class.
  */
 @RetryOnFailure
 public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActivity>
         implements ItemChooserDialog.ItemSelectedCallback {
 
     ItemChooserDialog mChooserDialog;
 
     String mLastSelectedId = "None";
 
+    private ItemChooserDialog.ItemChooserRowIcon mTestIcon1;
+    private ItemChooserDialog.ItemChooserRowIcon mTestIcon2;
+
     public ItemChooserDialogTest() {
         super(ChromeActivity.class);
     }
 
     // ChromeActivityTestCaseBase:
 
     @Override
     protected void setUp() throws Exception {
         super.setUp();
-        mChooserDialog = createDialog();
+        Resources resources = getActivity().getResources();
+        mTestIcon1 = new ItemChooserDialog.ItemChooserRowIcon(
+                VectorDrawableCompat.create(resources,
+                        R.drawable.ic_signal_cellular_0_bar_grey600_24dp, null /* theme */),
+                VectorDrawableCompat.create(resources,
+                        R.drawable.ic_signal_cellular_0_bar_white_24dp, null /* theme */),
+                resources.getQuantityString(R.plurals.signal_strength_level_n_bars, 0, 0));
+
+        mTestIcon2 = new ItemChooserDialog.ItemChooserRowIcon(
+                VectorDrawableCompat.create(resources,
+                        R.drawable.ic_signal_cellular_1_bar_grey600_24dp, null /* theme */),
+                VectorDrawableCompat.create(resources,
+                        R.drawable.ic_signal_cellular_1_bar_white_24dp, null /* theme */),
+                resources.getQuantityString(R.plurals.signal_strength_level_n_bars, 1, 1));
     }
 
     @Override
     public void startMainActivity() throws InterruptedException {
         startMainActivityOnBlankPage();
     }
 
     // ItemChooserDialog.ItemSelectedCallback:
 
     @Override
     public void onItemSelected(String id) {
         mLastSelectedId = id;
     }
 
-    private ItemChooserDialog createDialog() {
+    private ItemChooserDialog createDialog(final boolean usingIcon) {
         SpannableString title = new SpannableString("title");
         SpannableString searching = new SpannableString("searching");
         SpannableString noneFound = new SpannableString("noneFound");
         SpannableString statusActive = new SpannableString("statusActive");
         SpannableString statusIdleNoneFound = new SpannableString("statusIdleNoneFound");
         SpannableString statusIdleSomeFound = new SpannableString("statusIdleSomeFound");
         String positiveButton = new String("positiveButton");
         final ItemChooserDialog.ItemChooserLabels labels =
                 new ItemChooserDialog.ItemChooserLabels(title, searching, noneFound, statusActive,
                         statusIdleNoneFound, statusIdleSomeFound, positiveButton);
         ItemChooserDialog dialog = ThreadUtils.runOnUiThreadBlockingNoException(
                 new Callable<ItemChooserDialog>() {
                         @Override
                         public ItemChooserDialog call() {
                             ItemChooserDialog dialog = new ItemChooserDialog(
-                                    getActivity(), ItemChooserDialogTest.this, labels);
+                                    getActivity(), ItemChooserDialogTest.this, labels, usingIcon);
                             return dialog;
                         }
                 });
         return dialog;
     }
 
     private void selectItem(Dialog dialog, int position, String expectedItemId,
             boolean expectedEnabledState) throws InterruptedException {
         final ListView items = (ListView) dialog.findViewById(R.id.items);
         final Button button = (Button) dialog.findViewById(R.id.positive);
@@ skipping 22 matching lines @@
 
         CriteriaHelper.pollUiThread(
                 Criteria.equals(expectedItemId, new Callable<String>() {
                     @Override
                     public String call() {
                         return mLastSelectedId;
                     }
                 }));
     }
 
+    private int getImageContainerVisibilityForItem(ListView items, int pos) {
+        final int first = items.getFirstVisiblePosition();
+        final int last = items.getLastVisiblePosition();
+
+        View item;
+        if (pos < first || pos > last) {
+            item = items.getAdapter().getView(pos, null, items);
+        } else {
+            final int visiblePos = pos - first;
+            item = items.getChildAt(visiblePos);
+        }
+        return item.findViewById(R.id.imageContainer).getVisibility();
+    }
+
     @LargeTest
     public void testSimpleItemSelection() throws InterruptedException {
+        mChooserDialog = createDialog(false /* usingIcon */);
+
         Dialog dialog = mChooserDialog.getDialogForTesting();
         assertTrue(dialog.isShowing());
 
         TextViewWithClickableSpans statusView = (TextViewWithClickableSpans)
                 dialog.findViewById(R.id.status);
         final ListView items = (ListView) dialog.findViewById(R.id.items);
         final Button button = (Button) dialog.findViewById(R.id.positive);
 
         // Before we add items to the dialog, the 'searching' message should be
         // showing, the Commit button should be disabled and the list view hidden.
@@ skipping 21 matching lines @@
         assertFalse(button.isEnabled());
 
         // Select the first item and verify it got selected.
         selectItem(dialog, 1, "key", true);
 
         mChooserDialog.dismiss();
     }
 
     @LargeTest
     public void testNoItemsAddedDiscoveryIdle() throws InterruptedException {
+        mChooserDialog = createDialog(false /* usingIcon */);
         Dialog dialog = mChooserDialog.getDialogForTesting();
         assertTrue(dialog.isShowing());
 
         TextViewWithClickableSpans statusView = (TextViewWithClickableSpans)
                 dialog.findViewById(R.id.status);
         final ListView items = (ListView) dialog.findViewById(R.id.items);
         final Button button = (Button) dialog.findViewById(R.id.positive);
 
         // Before we add items to the dialog, the 'searching' message should be
         // showing, the Commit button should be disabled and the list view hidden.
         assertEquals("searching", statusView.getText().toString());
         assertFalse(button.isEnabled());
         assertEquals(View.GONE, items.getVisibility());
 
         mChooserDialog.setIdleState();
 
         // Listview should now be showing empty, with an empty view visible to
         // drive home the point and a status message at the bottom.
         assertEquals(View.GONE, items.getVisibility());
         assertEquals(View.VISIBLE, items.getEmptyView().getVisibility());
         assertEquals("statusIdleNoneFound", statusView.getText().toString());
         assertFalse(button.isEnabled());
 
         mChooserDialog.dismiss();
     }
 
     @LargeTest
     public void testDisabledSelection() throws InterruptedException {
+        mChooserDialog = createDialog(false /* usingIcon */);
         Dialog dialog = mChooserDialog.getDialogForTesting();
         assertTrue(dialog.isShowing());
 
         mChooserDialog.addOrUpdateItem(new ItemChooserDialog.ItemChooserRow("key", "key"));
         mChooserDialog.addOrUpdateItem(new ItemChooserDialog.ItemChooserRow("key2", "key2"));
 
         // Disable one item and try to select it.
         mChooserDialog.setEnabled("key", false);
         selectItem(dialog, 1, "None", false);
         // The other is still selectable.
         selectItem(dialog, 2, "key2", true);
 
         mChooserDialog.dismiss();
     }
 
     @LargeTest
+    public void testNotUsingIconAdapterRows() throws InterruptedException {
+        mChooserDialog = createDialog(false /* usingIcon */);
+        Dialog dialog = mChooserDialog.getDialogForTesting();
+        assertTrue(dialog.isShowing());
+
+        ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
+        final ListView items = (ListView) dialog.findViewById(R.id.items);
+
+        // Initially the itemAdapter is empty.
+        assertTrue(itemAdapter.isEmpty());
+
+        // Add item 1 with no icon.
+        ItemChooserDialog.ItemChooserRow item1 =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        mChooserDialog.addOrUpdateItem(item1);
+        assertEquals(View.GONE, getImageContainerVisibilityForItem(items, 0));
+
+        ItemChooserDialog.ItemChooserRow item2 =
+                new ItemChooserDialog.ItemChooserRow("key2", "desc2", mTestIcon1);
+        mChooserDialog.addOrUpdateItem(item2);
+        assertEquals(View.GONE, getImageContainerVisibilityForItem(items, 1));
+
+        mChooserDialog.setIdleState();
+        mChooserDialog.dismiss();
+    }
+
+    @LargeTest
+    public void testUsingIconAdapterRows() throws InterruptedException {
+        mChooserDialog = createDialog(true /* usingIcon */);
+        Dialog dialog = mChooserDialog.getDialogForTesting();
+        assertTrue(dialog.isShowing());
+
+        ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
+        final ListView items = (ListView) dialog.findViewById(R.id.items);
+
+        // Initially the itemAdapter is empty.
+        assertTrue(itemAdapter.isEmpty());
+
+        // Add item 1 with no icon.
+        ItemChooserDialog.ItemChooserRow item1 =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        mChooserDialog.addOrUpdateItem(item1);
+        assertEquals(View.INVISIBLE, getImageContainerVisibilityForItem(items, 0));
+
+        ItemChooserDialog.ItemChooserRow item2 =
+                new ItemChooserDialog.ItemChooserRow("key2", "desc2", mTestIcon1);
+        mChooserDialog.addOrUpdateItem(item2);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 1));
+
+        mChooserDialog.setIdleState();
+        mChooserDialog.dismiss();
+    }
+
+    @LargeTest
+    public void testUpdateItemWithIconToNoIcon() throws InterruptedException {
+        mChooserDialog = createDialog(true /* usingIcon */);
+        Dialog dialog = mChooserDialog.getDialogForTesting();
+        assertTrue(dialog.isShowing());
+
+        ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
+        final ListView items = (ListView) dialog.findViewById(R.id.items);
+
+        // Initially the itemAdapter is empty.
+        assertTrue(itemAdapter.isEmpty());
+
+        // Add item 1.
+        ItemChooserDialog.ItemChooserRow item1 =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1", mTestIcon1);
+        mChooserDialog.addOrUpdateItem(item1);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 0));
+        assertEquals(1, itemAdapter.getCount());
+        assertEquals(itemAdapter.getItem(0), item1);
+
+        // Add item 1 with no icon.
+        ItemChooserDialog.ItemChooserRow item1WithNoIcon =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        mChooserDialog.addOrUpdateItem(item1WithNoIcon);
+        assertEquals(1, itemAdapter.getCount());
+        // We should still see the original item with the icon.
+        ItemChooserDialog.ItemChooserRow expectedItem =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1", mTestIcon1);
+        assertEquals(itemAdapter.getItem(0), expectedItem);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 0));
+
+        mChooserDialog.setIdleState();
+        mChooserDialog.dismiss();
+    }
+
+    @LargeTest
+    public void testUpdateItemWithNoIconToIcon() throws InterruptedException {
+        mChooserDialog = createDialog(true /* usingIcon */);
+        Dialog dialog = mChooserDialog.getDialogForTesting();
+        assertTrue(dialog.isShowing());
+
+        ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
+        final ListView items = (ListView) dialog.findViewById(R.id.items);
+
+        // Initially the itemAdapter is empty.
+        assertTrue(itemAdapter.isEmpty());
+
+        // Add item 1 with no icon.
+        ItemChooserDialog.ItemChooserRow item1WithNoIcon =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        mChooserDialog.addOrUpdateItem(item1WithNoIcon);
+        assertEquals(View.INVISIBLE, getImageContainerVisibilityForItem(items, 0));
+        assertEquals(1, itemAdapter.getCount());
+        assertEquals(itemAdapter.getItem(0), item1WithNoIcon);
+
+        // Add item 1 with icon.
+        ItemChooserDialog.ItemChooserRow item1 =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1", mTestIcon1);
+        mChooserDialog.addOrUpdateItem(item1);
+        assertEquals(1, itemAdapter.getCount());
+        ItemChooserDialog.ItemChooserRow expectedItem =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1", mTestIcon1);
+        assertEquals(itemAdapter.getItem(0), expectedItem);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 0));
+
+        mChooserDialog.setIdleState();
+        mChooserDialog.dismiss();
+    }
+
+    @LargeTest
+    public void testUpdateItemWithNoIconToNoIcon() throws InterruptedException {
+        mChooserDialog = createDialog(true /* usingIcon */);
+        Dialog dialog = mChooserDialog.getDialogForTesting();
+        assertTrue(dialog.isShowing());
+
+        ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
+        final ListView items = (ListView) dialog.findViewById(R.id.items);
+
+        // Initially the itemAdapter is empty.
+        assertTrue(itemAdapter.isEmpty());
+
+        // Add item 1 with no icon.
+        ItemChooserDialog.ItemChooserRow item1WithNoIcon =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        mChooserDialog.addOrUpdateItem(item1WithNoIcon);
+        assertEquals(View.INVISIBLE, getImageContainerVisibilityForItem(items, 0));
+        assertEquals(1, itemAdapter.getCount());
+        assertEquals(itemAdapter.getItem(0), item1WithNoIcon);
+
+        // Add item 1 with no icon again.
+        mChooserDialog.addOrUpdateItem(item1WithNoIcon);
+        assertEquals(1, itemAdapter.getCount());
+        ItemChooserDialog.ItemChooserRow expectedItem =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+        assertEquals(itemAdapter.getItem(0), expectedItem);
+        assertEquals(View.INVISIBLE, getImageContainerVisibilityForItem(items, 0));
+
+        mChooserDialog.setIdleState();
+        mChooserDialog.dismiss();
+    }
+

[juncai, 2016/09/26 18:49:01]

Maybe add some test code to test different color icon is shown when row
selection is changed:
1. select a row and then unselect that row.
2. select a row and then select another row.

+    @LargeTest
     public void testAddOrUpdateItemAndRemoveItemFromList() throws InterruptedException {
+        mChooserDialog = createDialog(true /* usingIcon */);
         Dialog dialog = mChooserDialog.getDialogForTesting();
         assertTrue(dialog.isShowing());
 
         TextViewWithClickableSpans statusView = (TextViewWithClickableSpans)
                 dialog.findViewById(R.id.status);
         final ListView items = (ListView) dialog.findViewById(R.id.items);
         final Button button = (Button) dialog.findViewById(R.id.positive);
 
         ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
         ItemChooserDialog.ItemChooserRow nonExistentItem =
                 new ItemChooserDialog.ItemChooserRow("key", "key");
 
         // Initially the itemAdapter is empty.
         assertTrue(itemAdapter.isEmpty());
 
         // Try removing an item from an empty itemAdapter.
         mChooserDialog.removeItemFromList(nonExistentItem);
         assertTrue(itemAdapter.isEmpty());
 
         // Add item 1.
         ItemChooserDialog.ItemChooserRow item1 =
-                new ItemChooserDialog.ItemChooserRow("key1", "desc1");
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1", mTestIcon1);
         mChooserDialog.addOrUpdateItem(item1);
         assertEquals(1, itemAdapter.getCount());
         assertEquals(itemAdapter.getItem(0), item1);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 0));
 
-        // Add item 1 with different description.
-        ItemChooserDialog.ItemChooserRow item1_again =
-                new ItemChooserDialog.ItemChooserRow("key1", "desc1_again");
-        mChooserDialog.addOrUpdateItem(item1_again);
+        // Add item 1 with different description and icon.
+        ItemChooserDialog.ItemChooserRow item1Again =
+                new ItemChooserDialog.ItemChooserRow("key1", "desc1_again", mTestIcon2);
+        mChooserDialog.addOrUpdateItem(item1Again);
         assertEquals(1, itemAdapter.getCount());
-        assertEquals(itemAdapter.getItem(0), item1_again);
+        assertEquals(itemAdapter.getItem(0), item1Again);
+        assertEquals(View.VISIBLE, getImageContainerVisibilityForItem(items, 0));
 
         // Add item 2.
         ItemChooserDialog.ItemChooserRow item2 =
                 new ItemChooserDialog.ItemChooserRow("key2", "desc2");
         mChooserDialog.addOrUpdateItem(item2);
         assertEquals(2, itemAdapter.getCount());
-        assertEquals(itemAdapter.getItem(0), item1_again);
+        assertEquals(itemAdapter.getItem(0), item1Again);
         assertEquals(itemAdapter.getItem(1), item2);
+        assertEquals(View.INVISIBLE, getImageContainerVisibilityForItem(items, 1));
 
         mChooserDialog.setIdleState();
 
         // Try removing an item that doesn't exist.
         mChooserDialog.removeItemFromList(nonExistentItem);
         assertEquals(2, itemAdapter.getCount());
 
         // Remove item 2.
         mChooserDialog.removeItemFromList(item2);
         assertEquals(1, itemAdapter.getCount());
-        assertEquals(itemAdapter.getItem(0), item1_again);
+        assertEquals(itemAdapter.getItem(0), item1Again);
 
         // The list should be visible with one item, it should not show
         // the empty view and the button should not be enabled.
         // The chooser should show a status message at the bottom.
         assertEquals(View.VISIBLE, items.getVisibility());
         assertEquals(View.GONE, items.getEmptyView().getVisibility());
         assertEquals("statusIdleSomeFound", statusView.getText().toString());
         assertFalse(button.isEnabled());
 
         // Remove item 1.
-        mChooserDialog.removeItemFromList(item1_again);
+        mChooserDialog.removeItemFromList(item1Again);
         assertTrue(itemAdapter.isEmpty());
 
         // Listview should now be showing empty, with an empty view visible
         // and the button should not be enabled.
         // The chooser should show a status message at the bottom.
         assertEquals(View.GONE, items.getVisibility());
         assertEquals(View.VISIBLE, items.getEmptyView().getVisibility());
         assertEquals("statusIdleNoneFound", statusView.getText().toString());
         assertFalse(button.isEnabled());
 
         mChooserDialog.dismiss();
     }
 
     @LargeTest
     public void testAddItemWithSameNameToListAndRemoveItemFromList() throws InterruptedException {
+        mChooserDialog = createDialog(false /* usingIcon */);
         Dialog dialog = mChooserDialog.getDialogForTesting();
         assertTrue(dialog.isShowing());
 
         ItemChooserDialog.ItemAdapter itemAdapter = mChooserDialog.getItemAdapterForTesting();
 
         // Add item 1.
         ItemChooserDialog.ItemChooserRow item1 =
                 new ItemChooserDialog.ItemChooserRow("device_id_1", "same_device_name");
         mChooserDialog.addOrUpdateItem(item1);
         assertEquals(1, itemAdapter.getCount());
@@ skipping 53 matching lines @@
 
         // 1460 * .3 is 438, which rounds above the maximum height.
         assertEquals(408, ItemChooserDialog.getListHeight(1460, 1.0f));
 
         // 1100px is 500dp at a density of 2.2. 500 * .3 is 150dp, which is 48dp *
         // 3.125. 48dp * 3.5 is 168dp. 168dp * 2.2px/dp is 369.6, which rounds to
         // 370.
         assertEquals(370, ItemChooserDialog.getListHeight(1100, 2.2f));
     }
 }