Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 164 <ignore regexp="chromecast/internal" /> | 164 <ignore regexp="chromecast/internal" /> |
| 165 <ignore regexp="restriction_values.xml.*" /> | 165 <ignore regexp="restriction_values.xml.*" /> |
| 166 </issue> | 166 </issue> |
| 167 <issue id="MissingVersion"> | 167 <issue id="MissingVersion"> |
| 168 <ignore path="AndroidManifest.xml" /> | 168 <ignore path="AndroidManifest.xml" /> |
| 169 </issue> | 169 </issue> |
| 170 <issue id="NewApi"> | 170 <issue id="NewApi"> |
| 171 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17" /> | 171 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17" /> |
| 172 <ignore regexp="chrome/android/java/res/values-v17/styles.xml" /> | 172 <ignore regexp="chrome/android/java/res/values-v17/styles.xml" /> |
| 173 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml" /> | 173 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml" /> |
| 174 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_0_bar_gr ey600_24dp.xml" /> | |
|
Ian Wen
2016/09/26 18:12:48
Are you sure the suppression is needed? It seems d
ortuno
2016/09/26 23:34:48
Maybe I'm missing something but downloads_big.xml
| |
| 175 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_0_bar_wh ite_24dp.xml" /> | |
| 176 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_1_bar_gr ey600_24dp.xml" /> | |
| 177 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_1_bar_wh ite_24dp.xml" /> | |
| 178 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_2_bar_gr ey600_24dp.xml" /> | |
| 179 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_2_bar_wh ite_24dp.xml" /> | |
| 180 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_3_bar_gr ey600_24dp.xml" /> | |
| 181 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_3_bar_wh ite_24dp.xml" /> | |
| 182 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_4_bar_gr ey600_24dp.xml" /> | |
| 183 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_4_bar_wh ite_24dp.xml" /> | |
| 174 <ignore regexp="chromecast/internal" /> | 184 <ignore regexp="chromecast/internal" /> |
| 175 <ignore regexp="com/android/tv" /> | 185 <ignore regexp="com/android/tv" /> |
| 176 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class" /> | 186 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class" /> |
| 177 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" /> | 187 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" /> |
| 178 <ignore regexp="com/google/android/apps/cast" /> | 188 <ignore regexp="com/google/android/apps/cast" /> |
| 179 <ignore regexp="com/google/android/apps/mediashell" /> | 189 <ignore regexp="com/google/android/apps/mediashell" /> |
| 180 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas s" /> | 190 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas s" /> |
| 181 <ignore regexp="org/chromium/base/JavaHandlerThread.class" /> | 191 <ignore regexp="org/chromium/base/JavaHandlerThread.class" /> |
| 182 <ignore regexp="org/chromium/base/SysUtils.class" /> | 192 <ignore regexp="org/chromium/base/SysUtils.class" /> |
| 183 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class" /> | 193 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class" /> |
| (...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 299 </issue> | 309 </issue> |
| 300 <issue id="ViewConstructor" severity="ignore" /> | 310 <issue id="ViewConstructor" severity="ignore" /> |
| 301 <issue id="WrongCall" severity="ignore" /> | 311 <issue id="WrongCall" severity="ignore" /> |
| 302 <issue id="WrongConstant"> | 312 <issue id="WrongConstant"> |
| 303 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> | 313 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> |
| 304 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> | 314 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> |
| 305 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> | 315 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> |
| 306 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> | 316 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> |
| 307 </issue> | 317 </issue> |
| 308 </lint> | 318 </lint> |
| OLD | NEW |