Wires up drags to pointer watcher adapter.

ash/aura/pointer_watcher_adapter_unittest.cc

Index: ash/aura/pointer_watcher_adapter_unittest.cc
diff --git a/ash/aura/pointer_watcher_adapter_unittest.cc b/ash/aura/pointer_watcher_adapter_unittest.cc
index 8f95473edfeec783507e27ffe978ca8f1458f7c6..4af3ade2d672d98e9ecdec03a084c4367ac1a01d 100644
--- a/ash/aura/pointer_watcher_adapter_unittest.cc
+++ b/ash/aura/pointer_watcher_adapter_unittest.cc
@@ -14,24 +14,33 @@ namespace ash {
 
 using PointerWatcherAdapterTest = test::AshTestBase;
 
+enum TestPointerCaptureEvents {
+  NONE = 0x01,
+  CAPTURE = 0x02,
+  WHEEL = 0x04,
+  PRESS_OR_RELEASE = 0x08,
+  MOVE_OR_DRAG = 0x10,
+};
+
 // Records calls to OnPointerEventObserved() in |mouse_wheel_event_count| for a
 // mouse wheel event, in |capture_changed_count_| for a mouse capture change
 // event and in |pointer_event_count_| for all other pointer events.
 class TestPointerWatcher : public views::PointerWatcher {
  public:
-  explicit TestPointerWatcher(bool wants_moves) {
-    WmShell::Get()->AddPointerWatcher(this, wants_moves);
+  explicit TestPointerWatcher(views::PointerWatcherEventTypes events) {
+    WmShell::Get()->AddPointerWatcher(this, events);
   }
   ~TestPointerWatcher() override { WmShell::Get()->RemovePointerWatcher(this); }
 
   void ClearCounts() {
     pointer_event_count_ = capture_changed_count_ = mouse_wheel_event_count_ =
-        0;
+        move_drag_changed_count_ = 0;
   }
 
   int pointer_event_count() const { return pointer_event_count_; }
   int capture_changed_count() const { return capture_changed_count_; }
   int mouse_wheel_event_count() const { return mouse_wheel_event_count_; }
+  int move_drag_changed_count() const { return move_drag_changed_count_; }
 
   // views::PointerWatcher:
   void OnPointerEventObserved(const ui::PointerEvent& event,
@@ -41,6 +50,8 @@ class TestPointerWatcher : public views::PointerWatcher {
       mouse_wheel_event_count_++;
     else if (event.type() == ui::ET_POINTER_CAPTURE_CHANGED)
       capture_changed_count_++;
+    else if (event.type() == ui::ET_POINTER_MOVED)

[sky, 2016/09/01 02:54:14]

Sorry for not realizing this last time. The way you have this now it isn't
possible to differentiate move from drag, which are enabled separately so I
think it's worth tracking separately. By that I mean make this more fine grained
so that you can track DRAG separate from MOVE. I think this is important given
the types are now unique. With what you have we wouldn't be able to detect a
regression.

[sammiequon, 2016/09/01 17:06:48]

Sorry for all the back and forth. Is this way or adding ET_POINTER_DRAGGED the
correct way?

+      move_drag_changed_count_++;
     else
       pointer_event_count_++;
   }
@@ -49,42 +60,68 @@ class TestPointerWatcher : public views::PointerWatcher {
   int pointer_event_count_ = 0;
   int capture_changed_count_ = 0;
   int mouse_wheel_event_count_ = 0;
+  int move_drag_changed_count_ = 0;
 
   DISALLOW_COPY_AND_ASSIGN(TestPointerWatcher);
 };
 
-// Creates two TestPointerWatchers, one that wants moves and one that doesn't.
+// Creates three TestPointerWatchers, one that wants moves and one that wants
+// drags, and one that does not want either.
 class TestHelper {
  public:
-  TestHelper() : non_move_watcher_(false), move_watcher_(true) {}
+  TestHelper()
+      : basic_watcher_(views::PointerWatcherEventTypes::BASIC),
+        move_watcher_(views::PointerWatcherEventTypes::MOVES),
+        drag_watcher_(views::PointerWatcherEventTypes::DRAGS) {}
   ~TestHelper() {}
 
-  // Used to verify call counts.
-  void ExpectCallCount(int non_move_pointer_event_count,
-                       int non_move_capture_changed_count,
-                       int non_move_mouse_wheel_event_count,
-                       int move_pointer_event_count,
-                       int move_capture_changed_count,
-                       int move_mouse_wheel_event_count) {
-    EXPECT_EQ(non_move_pointer_event_count,
-              non_move_watcher_.pointer_event_count());
-    EXPECT_EQ(non_move_capture_changed_count,
-              non_move_watcher_.capture_changed_count());
-    EXPECT_EQ(non_move_mouse_wheel_event_count,
-              non_move_watcher_.mouse_wheel_event_count());
-    EXPECT_EQ(move_pointer_event_count, move_watcher_.pointer_event_count());
-    EXPECT_EQ(move_capture_changed_count,
+  // Used to verify call counts. One ExpectCallCount call should be made after
+  // each generated mouse events. |basic_events_bitmask| defines which events
+  // the test basic watcher should receive and |move_events_bitamsk| defines
+  // which events the test move watcher should receive and |drag_events_bitmask|
+  // defines which events the test drag watcher should receive.
+  void ExpectCallCount(int basic_events_bitmask,
+                       int move_events_bitmask,
+                       int drag_events_bitmask) {
+    // Compare the expected events in the |basic_events_bitmask| with the actual
+    // counts. Basic watcher should never have any move drag counts.
+    EXPECT_EQ(0, basic_watcher_.move_drag_changed_count());
+    EXPECT_EQ(basic_events_bitmask & PRESS_OR_RELEASE ? 1 : 0,
+              basic_watcher_.pointer_event_count());
+    EXPECT_EQ(basic_events_bitmask & CAPTURE ? 1 : 0,
+              basic_watcher_.capture_changed_count());
+    EXPECT_EQ(basic_events_bitmask & WHEEL ? 1 : 0,
+              basic_watcher_.mouse_wheel_event_count());
+    // Compare the expected events in the |move_events_bitmask| with the actual
+    // counts.
+    EXPECT_EQ(move_events_bitmask & MOVE_OR_DRAG ? 1 : 0,
+              move_watcher_.move_drag_changed_count());
+    EXPECT_EQ(move_events_bitmask & PRESS_OR_RELEASE ? 1 : 0,
+              move_watcher_.pointer_event_count());
+    EXPECT_EQ(move_events_bitmask & CAPTURE ? 1 : 0,
               move_watcher_.capture_changed_count());
-    EXPECT_EQ(move_mouse_wheel_event_count,
+    EXPECT_EQ(move_events_bitmask & WHEEL ? 1 : 0,
               move_watcher_.mouse_wheel_event_count());
-
-    non_move_watcher_.ClearCounts();
+    // Compare the expected events in the |drag_events_bitmask| with the actual
+    // counts.
+    EXPECT_EQ(drag_events_bitmask & MOVE_OR_DRAG ? 1 : 0,
+              drag_watcher_.move_drag_changed_count());
+    EXPECT_EQ(drag_events_bitmask & PRESS_OR_RELEASE ? 1 : 0,
+              drag_watcher_.pointer_event_count());
+    EXPECT_EQ(drag_events_bitmask & CAPTURE ? 1 : 0,
+              drag_watcher_.capture_changed_count());
+    EXPECT_EQ(drag_events_bitmask & WHEEL ? 1 : 0,
+              drag_watcher_.mouse_wheel_event_count());
+
+    basic_watcher_.ClearCounts();
     move_watcher_.ClearCounts();
+    drag_watcher_.ClearCounts();
   }
 
  private:
-  TestPointerWatcher non_move_watcher_;
+  TestPointerWatcher basic_watcher_;
   TestPointerWatcher move_watcher_;
+  TestPointerWatcher drag_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(TestHelper);
 };
@@ -92,59 +129,60 @@ class TestHelper {
 TEST_F(PointerWatcherAdapterTest, MouseEvents) {
   TestHelper helper;
 
-  // Move: only the move PointerWatcher should get the event.
+  // Move: only the move and drag PointerWatcher should get the event.
   GetEventGenerator().MoveMouseTo(gfx::Point(10, 10));
-  helper.ExpectCallCount(0, 0, 0, 1, 0, 0);
+  helper.ExpectCallCount(NONE, MOVE_OR_DRAG, MOVE_OR_DRAG);
 
-  // Press: both.
+  // Press: all.
   GetEventGenerator().PressLeftButton();
-  helper.ExpectCallCount(1, 0, 0, 1, 0, 0);
+  helper.ExpectCallCount(PRESS_OR_RELEASE, PRESS_OR_RELEASE, PRESS_OR_RELEASE);
 
-  // Drag: none.
+  // Drag: only drag PointerWatcher should get the event.
   GetEventGenerator().MoveMouseTo(gfx::Point(20, 30));
-  helper.ExpectCallCount(0, 0, 0, 0, 0, 0);
+  helper.ExpectCallCount(NONE, NONE, MOVE_OR_DRAG);
 
-  // Release: both (aura generates a capture event here).
+  // Release: all (aura generates a capture event here).
   GetEventGenerator().ReleaseLeftButton();
-  helper.ExpectCallCount(1, 1, 0, 1, 1, 0);
+  helper.ExpectCallCount(CAPTURE | PRESS_OR_RELEASE, CAPTURE | PRESS_OR_RELEASE,
+                         CAPTURE | PRESS_OR_RELEASE);
 
   // Exit: none.
   GetEventGenerator().SendMouseExit();
-  helper.ExpectCallCount(0, 0, 0, 0, 0, 0);
+  helper.ExpectCallCount(NONE, NONE, NONE);
 
   // Enter: none.
   ui::MouseEvent enter_event(ui::ET_MOUSE_ENTERED, gfx::Point(), gfx::Point(),
                              ui::EventTimeForNow(), 0, 0);
   GetEventGenerator().Dispatch(&enter_event);
-  helper.ExpectCallCount(0, 0, 0, 0, 0, 0);
+  helper.ExpectCallCount(NONE, NONE, NONE);
 
-  // Wheel: both
+  // Wheel: all
   GetEventGenerator().MoveMouseWheel(10, 11);
-  helper.ExpectCallCount(0, 0, 1, 0, 0, 1);
+  helper.ExpectCallCount(WHEEL, WHEEL, WHEEL);
 
-  // Capture: both.
+  // Capture: all.
   ui::MouseEvent capture_event(ui::ET_MOUSE_CAPTURE_CHANGED, gfx::Point(),
                                gfx::Point(), ui::EventTimeForNow(), 0, 0);
   GetEventGenerator().Dispatch(&capture_event);
-  helper.ExpectCallCount(0, 1, 0, 0, 1, 0);
+  helper.ExpectCallCount(CAPTURE, CAPTURE, CAPTURE);
 }
 
 TEST_F(PointerWatcherAdapterTest, TouchEvents) {
   TestHelper helper;
 
-  // Press: both.
+  // Press: all.
   const int touch_id = 11;
   GetEventGenerator().PressTouchId(touch_id);
-  helper.ExpectCallCount(1, 0, 0, 1, 0, 0);
+  helper.ExpectCallCount(PRESS_OR_RELEASE, PRESS_OR_RELEASE, PRESS_OR_RELEASE);
 
-  // Drag: none.
+  // Drag: only drag.
   GetEventGenerator().MoveTouchId(gfx::Point(20, 30), touch_id);
-  helper.ExpectCallCount(0, 0, 0, 0, 0, 0);
+  helper.ExpectCallCount(NONE, NONE, MOVE_OR_DRAG);
 
   // Release: both (contrary to mouse above, touch does not implicitly generate
   // capture).
   GetEventGenerator().ReleaseTouchId(touch_id);
-  helper.ExpectCallCount(1, 0, 0, 1, 0, 0);
+  helper.ExpectCallCount(PRESS_OR_RELEASE, PRESS_OR_RELEASE, PRESS_OR_RELEASE);
 }
 
 }  // namespace ash