Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: ash/aura/pointer_watcher_adapter.cc

Issue 2271393002: Wires up drags to pointer watcher adapter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/aura/pointer_watcher_adapter.h" 5 #include "ash/aura/pointer_watcher_adapter.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ui/aura/client/screen_position_client.h" 8 #include "ui/aura/client/screen_position_client.h"
9 #include "ui/aura/window.h" 9 #include "ui/aura/window.h"
10 #include "ui/events/event.h" 10 #include "ui/events/event.h"
11 #include "ui/events/event_constants.h" 11 #include "ui/events/event_constants.h"
12 #include "ui/gfx/geometry/point.h" 12 #include "ui/gfx/geometry/point.h"
13 #include "ui/views/pointer_watcher.h" 13 #include "ui/views/pointer_watcher.h"
14 #include "ui/views/widget/widget.h" 14 #include "ui/views/widget/widget.h"
15 15
16 namespace ash { 16 namespace ash {
17 17
18 PointerWatcherAdapter::PointerWatcherAdapter() { 18 PointerWatcherAdapter::PointerWatcherAdapter() {
19 Shell::GetInstance()->AddPreTargetHandler(this); 19 Shell::GetInstance()->AddPreTargetHandler(this);
20 } 20 }
21 21
22 PointerWatcherAdapter::~PointerWatcherAdapter() { 22 PointerWatcherAdapter::~PointerWatcherAdapter() {
23 Shell::GetInstance()->RemovePreTargetHandler(this); 23 Shell::GetInstance()->RemovePreTargetHandler(this);
24 } 24 }
25 25
26 void PointerWatcherAdapter::AddPointerWatcher(views::PointerWatcher* watcher, 26 void PointerWatcherAdapter::AddPointerWatcher(views::PointerWatcher* watcher,
27 bool wants_moves) { 27 bool wants_moves,
28 bool wants_drags) {
28 // We only allow a watcher to be added once. That is, we don't consider 29 // We only allow a watcher to be added once. That is, we don't consider
29 // the pair of |watcher| and |wants_move| unique, just |watcher|. 30 // the pair of |watcher| and |wants_move| and |wants_drags| unique, just
30 if (wants_moves) { 31 // |watcher|.
32 if (wants_drags) {
33 DCHECK(!move_watchers_.HasObserver(watcher));
34 DCHECK(!non_move_watchers_.HasObserver(watcher));
35 drag_watchers_.AddObserver(watcher);
36 } else if (wants_moves) {
37 DCHECK(!drag_watchers_.HasObserver(watcher));
31 DCHECK(!non_move_watchers_.HasObserver(watcher)); 38 DCHECK(!non_move_watchers_.HasObserver(watcher));
32 move_watchers_.AddObserver(watcher); 39 move_watchers_.AddObserver(watcher);
33 } else { 40 } else {
41 DCHECK(!drag_watchers_.HasObserver(watcher));
34 DCHECK(!move_watchers_.HasObserver(watcher)); 42 DCHECK(!move_watchers_.HasObserver(watcher));
35 non_move_watchers_.AddObserver(watcher); 43 non_move_watchers_.AddObserver(watcher);
36 } 44 }
37 } 45 }
38 46
39 void PointerWatcherAdapter::RemovePointerWatcher( 47 void PointerWatcherAdapter::RemovePointerWatcher(
40 views::PointerWatcher* watcher) { 48 views::PointerWatcher* watcher) {
41 non_move_watchers_.RemoveObserver(watcher); 49 non_move_watchers_.RemoveObserver(watcher);
42 move_watchers_.RemoveObserver(watcher); 50 move_watchers_.RemoveObserver(watcher);
51 drag_watchers_.RemoveObserver(watcher);
43 } 52 }
44 53
45 void PointerWatcherAdapter::OnMouseEvent(ui::MouseEvent* event) { 54 void PointerWatcherAdapter::OnMouseEvent(ui::MouseEvent* event) {
46 if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED) { 55 if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED) {
47 FOR_EACH_OBSERVER(views::PointerWatcher, non_move_watchers_, 56 FOR_EACH_OBSERVER(views::PointerWatcher, non_move_watchers_,
48 OnMouseCaptureChanged()); 57 OnMouseCaptureChanged());
49 FOR_EACH_OBSERVER(views::PointerWatcher, move_watchers_, 58 FOR_EACH_OBSERVER(views::PointerWatcher, move_watchers_,
50 OnMouseCaptureChanged()); 59 OnMouseCaptureChanged());
60 FOR_EACH_OBSERVER(views::PointerWatcher, drag_watchers_,
61 OnMouseCaptureChanged());
51 return; 62 return;
52 } 63 }
53 64
54 // For compatibility with the mus version, don't send drags. 65 // The mus version does not send drags.
55 if (event->type() != ui::ET_MOUSE_PRESSED && 66 if (event->type() != ui::ET_MOUSE_PRESSED &&
56 event->type() != ui::ET_MOUSE_RELEASED && 67 event->type() != ui::ET_MOUSE_RELEASED &&
57 event->type() != ui::ET_MOUSE_MOVED) 68 event->type() != ui::ET_MOUSE_MOVED &&
69 event->type() != ui::ET_MOUSE_DRAGGED)
58 return; 70 return;
59 71
60 DCHECK(ui::PointerEvent::CanConvertFrom(*event)); 72 DCHECK(ui::PointerEvent::CanConvertFrom(*event));
61 NotifyWatchers(ui::PointerEvent(*event), *event); 73 NotifyWatchers(ui::PointerEvent(*event), *event);
62 } 74 }
63 75
64 void PointerWatcherAdapter::OnTouchEvent(ui::TouchEvent* event) { 76 void PointerWatcherAdapter::OnTouchEvent(ui::TouchEvent* event) {
65 // For compatibility with the mus version, don't send drags. 77 // For compatibility with the mus version, don't send drags.
66 if (event->type() != ui::ET_TOUCH_PRESSED && 78 if (event->type() != ui::ET_TOUCH_PRESSED &&
67 event->type() != ui::ET_TOUCH_RELEASED) 79 event->type() != ui::ET_TOUCH_RELEASED)
(...skipping 17 matching lines...) Expand all
85 aura::Window* window = static_cast<aura::Window*>(event.target()); 97 aura::Window* window = static_cast<aura::Window*>(event.target());
86 return views::Widget::GetTopLevelWidgetForNativeView(window); 98 return views::Widget::GetTopLevelWidgetForNativeView(window);
87 } 99 }
88 100
89 void PointerWatcherAdapter::NotifyWatchers( 101 void PointerWatcherAdapter::NotifyWatchers(
90 const ui::PointerEvent& event, 102 const ui::PointerEvent& event,
91 const ui::LocatedEvent& original_event) { 103 const ui::LocatedEvent& original_event) {
92 const gfx::Point screen_location(GetLocationInScreen(original_event)); 104 const gfx::Point screen_location(GetLocationInScreen(original_event));
93 views::Widget* target_widget = GetTargetWidget(original_event); 105 views::Widget* target_widget = GetTargetWidget(original_event);
94 FOR_EACH_OBSERVER( 106 FOR_EACH_OBSERVER(
95 views::PointerWatcher, move_watchers_, 107 views::PointerWatcher, drag_watchers_,
96 OnPointerEventObserved(event, screen_location, target_widget)); 108 OnPointerEventObserved(event, screen_location, target_widget));
97 if (event.type() != ui::ET_POINTER_MOVED) { 109 if (original_event.type() != ui::ET_MOUSE_DRAGGED) {
110 FOR_EACH_OBSERVER(
111 views::PointerWatcher, move_watchers_,
112 OnPointerEventObserved(event, screen_location, target_widget));
113 }
114 if (event.type() != ui::ET_POINTER_MOVED &&
115 original_event.type() != ui::ET_MOUSE_DRAGGED) {
98 FOR_EACH_OBSERVER( 116 FOR_EACH_OBSERVER(
99 views::PointerWatcher, non_move_watchers_, 117 views::PointerWatcher, non_move_watchers_,
100 OnPointerEventObserved(event, screen_location, target_widget)); 118 OnPointerEventObserved(event, screen_location, target_widget));
101 } 119 }
102 } 120 }
103 121
104 } // namespace ash 122 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698