Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2271383003: gn: Don't read unitialized memory on files containing just a comment. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Don't read unitialized memory on files containing just a comment. The BlockNode::GetRange() of a block containing nothing doesn't have an initialized bytes_ member. Skip empty nodes, they'll be assinged to the file block further down. Patch sketch by scottmg. BUG=640856 Committed: https://crrev.com/c3b455922b7ddb748e9a7b351cac7a4586c7e374 Cr-Commit-Position: refs/heads/master@{#414522}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : _EQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/gn/parser.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
Maybe like so?
4 years, 3 months ago (2016-08-25 19:32:47 UTC) #4
scottmg
poing! lgtm
4 years, 3 months ago (2016-08-25 19:46:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271383003/40001
4 years, 3 months ago (2016-08-25 19:48:34 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-25 20:22:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 20:24:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c3b455922b7ddb748e9a7b351cac7a4586c7e374
Cr-Commit-Position: refs/heads/master@{#414522}

Powered by Google App Engine
This is Rietveld 408576698