Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2271373003: Fix infinite loops in FPDF_GetFullName(). (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix infinite loops in FPDF_GetFullName(). BUG=444446 Committed: https://pdfium.googlesource.com/pdfium/+/695aac5f1f53088659f9b525a692002044e3b098

Patch Set 1 #

Patch Set 2 : Test, lint error -> checked_cast #

Patch Set 3 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -4 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 4 chunks +11 lines, -4 lines 0 comments Download
A core/fpdfdoc/cpdf_formfield_unittest.cpp View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Lei Zhang
Maybe we should audit all the GetDictBy("Parent") calls.
4 years, 3 months ago (2016-08-25 00:36:14 UTC) #4
dsinclair
lgtm. Can you write a couple unittests for this?
4 years, 3 months ago (2016-08-25 13:43:38 UTC) #7
Lei Zhang
PTAL
4 years, 3 months ago (2016-08-25 15:47:57 UTC) #12
dsinclair
lgtm
4 years, 3 months ago (2016-08-25 15:49:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271373003/40001
4 years, 3 months ago (2016-08-25 16:13:37 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:13:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/695aac5f1f53088659f9b525a692002044e3...

Powered by Google App Engine
This is Rietveld 408576698