mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693, 629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org

Committed: https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213
Cr-Commit-Position: refs/heads/master@{#414561}

[msw, 2016-08-24 23:37:49]

Description was changed from

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

BUG=640693
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org
==========

to

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
==========

[msw, 2016-08-24 23:37:49]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-08-24 23:39:13]

Hey James and Scott, please take a look:
James: please review ash/* (minus ash/mus/*)
Scott: please review ash/mus/* and chrome/*

[msw, 2016-08-24 23:39:20]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:44:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2016-08-25 00:00:32]

LGTM - it would be good to have test coverage, but no doubt that will come
later.

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/context_menu_mus.h
File ash/mus/context_menu_mus.h (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/context_menu_mu...
ash/mus/context_menu_mus.h:17: // TODO(mash): Mimic logic in
LauncherContextMenu.
Unless mash is a real person I would remove the (mash) part. I also recommend
filing a bug.

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
File ash/mus/native_widget_factory_mus.cc (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
ash/mus/native_widget_factory_mus.cc:24: // TYPE_CONTROL widgets require a
NativeWidgetAura. So we let this fall
I'm not sure this comment is really valid here, but we'll see...

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
File ash/mus/native_widget_factory_mus.h (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
ash/mus/native_widget_factory_mus.h:16: // For example, this creatse context
menu widgets for the shelf and wallpaper.
creatse -> creates

https://codereview.chromium.org/2271373002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/background/ash_wallpaper_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/background/ash_wallpaper_delegate.h:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
2016?

[msw, 2016-08-25 00:24:37]

Description was changed from

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
==========

to

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
==========

[msw, 2016-08-25 00:25:14]

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/context_menu_mus.h
File ash/mus/context_menu_mus.h (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/context_menu_mu...
ash/mus/context_menu_mus.h:17: // TODO(mash): Mimic logic in
LauncherContextMenu.
On 2016/08/25 00:00:32, sky wrote:
> Unless mash is a real person I would remove the (mash) part. I also recommend
> filing a bug.

Done.

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
File ash/mus/native_widget_factory_mus.cc (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
ash/mus/native_widget_factory_mus.cc:24: // TYPE_CONTROL widgets require a
NativeWidgetAura. So we let this fall
On 2016/08/25 00:00:32, sky wrote:
> I'm not sure this comment is really valid here, but we'll see...

Acknowledged. Sorry that I'm quite familiar with this bit.

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
File ash/mus/native_widget_factory_mus.h (right):

https://codereview.chromium.org/2271373002/diff/40001/ash/mus/native_widget_f...
ash/mus/native_widget_factory_mus.h:16: // For example, this creatse context
menu widgets for the shelf and wallpaper.
On 2016/08/25 00:00:32, sky wrote:
> creatse -> creates

Done.

https://codereview.chromium.org/2271373002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/background/ash_wallpaper_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/background/ash_wallpaper_delegate.h:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
On 2016/08/25 00:00:32, sky wrote:
> 2016?

Done. (and in .cc file, but these were just file renames)

[msw, 2016-08-25 00:25:27]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 00:26:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 01:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 01:29:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msw, 2016-08-25 05:35:35]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 05:36:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 06:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 06:44:26]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msw, 2016-08-25 16:41:16]

Scott, I moved factory ownership to WindowManagerApplication; to better match
AuraInit/ViewsDelegate.
James, please take a look; thanks.

[James Cook, 2016-08-25 16:59:57]

ash/* LGTM with a request for std::unique_ptr<>

https://codereview.chromium.org/2271373002/diff/100001/ash/common/shell_deleg...
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/100001/ash/common/shell_deleg...
ash/common/shell_delegate.h:112: virtual WallpaperDelegate*
CreateWallpaperDelegate() = 0;
Return std::unique_ptr<> instead?

https://codereview.chromium.org/2271373002/diff/100001/ash/default_wallpaper_...
File ash/default_wallpaper_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/100001/ash/default_wallpaper_...
ash/default_wallpaper_delegate.h:10: #include "base/compiler_specific.h"
nit: remove

[msw, 2016-08-25 18:24:51]

Patchset #7 (id:120001) has been deleted

[msw, 2016-08-25 18:25:23]

Description was changed from

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
==========

to

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org
==========

[msw, 2016-08-25 18:25:23]

msw@chromium.org changed reviewers:
+ stevenjb@chromium.org, yusukes@chromium.org

[msw, 2016-08-25 18:27:06]

+TBR yusukes for components/arc/OWNERS
+TBR stevenjb for chrome/browser/ui/webui/options/OWNERS

https://codereview.chromium.org/2271373002/diff/100001/ash/common/shell_deleg...
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/100001/ash/common/shell_deleg...
ash/common/shell_delegate.h:112: virtual WallpaperDelegate*
CreateWallpaperDelegate() = 0;
On 2016/08/25 16:59:57, James Cook wrote:
> Return std::unique_ptr<> instead?
> 

Done.

https://codereview.chromium.org/2271373002/diff/100001/ash/default_wallpaper_...
File ash/default_wallpaper_delegate.h (right):

https://codereview.chromium.org/2271373002/diff/100001/ash/default_wallpaper_...
ash/default_wallpaper_delegate.h:10: #include "base/compiler_specific.h"
On 2016/08/25 16:59:57, James Cook wrote:
> nit: remove

Done.

[msw, 2016-08-25 18:27:20]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-25 18:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2271373002/#ps140001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-25 18:27:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-25 20:20:04]

Moving to WindowManagerApplication SLGTM (good thing I suggested you put the
code in a separate class, eh?)

[Yusuke Sato, 2016-08-25 20:21:03]

arc/ lgtm

[commit-bot: I haz the power, 2016-08-25 21:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:17:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[msw, 2016-08-25 21:25:55]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:27:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:34:29]

Description was changed from

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org
==========

to

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org
==========

[commit-bot: I haz the power, 2016-08-25 22:34:31]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-08-25 22:36:52]

Description was changed from

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org
==========

to

==========
mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG=640693,629605
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org

Committed: https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213
Cr-Commit-Position: refs/heads/master@{#414561}
==========

[commit-bot: I haz the power, 2016-08-25 22:36:54]

Patchset 7 (id:??) landed as
https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213
Cr-Commit-Position: refs/heads/master@{#414561}