Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: base/OWNERS

Issue 2271343002: Add agrieve as OWNER for base/android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/android/OWNERS » ('j') | base/android/OWNERS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # About src/base: 1 # About src/base:
2 # 2 #
3 # Chromium is a very mature project, most things that are generally useful are 3 # Chromium is a very mature project, most things that are generally useful are
4 # already here, and that things not here aren't generally useful. 4 # already here, and that things not here aren't generally useful.
5 # 5 #
6 # Base is pulled into many projects. For example, various ChromeOS daemons. So 6 # Base is pulled into many projects. For example, various ChromeOS daemons. So
7 # the bar for adding stuff is that it must have demonstrated wide 7 # the bar for adding stuff is that it must have demonstrated wide
8 # applicability. Prefer to add things closer to where they're used (i.e. "not 8 # applicability. Prefer to add things closer to where they're used (i.e. "not
9 # base"), and pull into base only when needed. In a project our size, 9 # base"), and pull into base only when needed. In a project our size,
10 # sometimes even duplication is OK and inevitable. 10 # sometimes even duplication is OK and inevitable.
(...skipping 12 matching lines...) Expand all
23 thestig@chromium.org 23 thestig@chromium.org
24 dcheng@chromium.org 24 dcheng@chromium.org
25 25
26 # For Bind/Callback: 26 # For Bind/Callback:
27 per-file bind*=tzik@chromium.org 27 per-file bind*=tzik@chromium.org
28 per-file callback*=tzik@chromium.org 28 per-file callback*=tzik@chromium.org
29 29
30 # For Android-specific changes: 30 # For Android-specific changes:
31 per-file *android*=file://base/android/OWNERS 31 per-file *android*=file://base/android/OWNERS
32 per-file BUILD.gn=file://base/android/OWNERS 32 per-file BUILD.gn=file://base/android/OWNERS
33 per-file BUILD.gn=file://build/OWNERS
Nico 2016/08/24 18:35:19 Why should build/OWNERS be owners of base/OWNERS,
agrieve 2016/08/24 18:42:38 This is just owners of base/BUILD.gn (not OWNERS).
33 34
34 # For FeatureList API: 35 # For FeatureList API:
35 per-file feature_list*=asvitkine@chromium.org 36 per-file feature_list*=asvitkine@chromium.org
36 per-file feature_list*=isherman@chromium.org 37 per-file feature_list*=isherman@chromium.org
37 38
38 # For bot infrastructure: 39 # For bot infrastructure:
39 per-file *.isolate=maruel@chromium.org 40 per-file *.isolate=maruel@chromium.org
40 per-file *.isolate=tandrii@chromium.org 41 per-file *.isolate=tandrii@chromium.org
41 per-file *.isolate=vadimsh@chromium.org 42 per-file *.isolate=vadimsh@chromium.org
42 43
43 # For TCMalloc tests: 44 # For TCMalloc tests:
44 per-file security_unittest.cc=jln@chromium.org 45 per-file security_unittest.cc=jln@chromium.org
OLDNEW
« no previous file with comments | « no previous file | base/android/OWNERS » ('j') | base/android/OWNERS » ('J')

Powered by Google App Engine
This is Rietveld 408576698