Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2271343002:
Add agrieve as OWNER for base/android (Closed)
DescriptionAdd agrieve as OWNER for base/android
Mainly for proguard and build rules changes.
Committed: https://crrev.com/6451e6497683be13f366f6c5c196b7a9d2027e71
Cr-Commit-Position: refs/heads/master@{#414264}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Add agrieve as OWNER for base proguard flags & BUILD.gn #
Total comments: 2
Patch Set 3 : sort #Messages
Total messages: 16 (7 generated)
agrieve@chromium.org changed reviewers: + thakis@chromium.org
https://codereview.chromium.org/2271343002/diff/1/base/OWNERS File base/OWNERS (right): https://codereview.chromium.org/2271343002/diff/1/base/OWNERS#newcode33 base/OWNERS:33: per-file BUILD.gn=file://build/OWNERS Why should build/OWNERS be owners of base/OWNERS, especially for Android-specific changes? If you think you should be here, either add ldap, or, probably better, become a base/android/OWNER? https://codereview.chromium.org/2271343002/diff/1/base/android/OWNERS File base/android/OWNERS (right): https://codereview.chromium.org/2271343002/diff/1/base/android/OWNERS#newcode6 base/android/OWNERS:6: per-file *.flags=agrieve@chromium.org This is fine with me, but should probably be stamped by a base/android/OWNER
Description was changed from ========== Add agrieve as OWNER for base proguard flags & BUILD.gn ========== to ========== Add agrieve as OWNER for base/android Mainly for proguard and build rules changes. ==========
agrieve@chromium.org changed reviewers: + nyquist@chromium.org - thakis@chromium.org
On 2016/08/24 18:35:19, Nico wrote: > https://codereview.chromium.org/2271343002/diff/1/base/OWNERS > File base/OWNERS (right): > > https://codereview.chromium.org/2271343002/diff/1/base/OWNERS#newcode33 > base/OWNERS:33: per-file BUILD.gn=file://build/OWNERS > Why should build/OWNERS be owners of base/OWNERS, especially for > Android-specific changes? If you think you should be here, either add ldap, or, > probably better, become a base/android/OWNER? > > https://codereview.chromium.org/2271343002/diff/1/base/android/OWNERS > File base/android/OWNERS (right): > > https://codereview.chromium.org/2271343002/diff/1/base/android/OWNERS#newcode6 > base/android/OWNERS:6: per-file mailto:*.flags=agrieve@chromium.org > This is fine with me, but should probably be stamped by a base/android/OWNER +nyquist
https://codereview.chromium.org/2271343002/diff/1/base/OWNERS File base/OWNERS (right): https://codereview.chromium.org/2271343002/diff/1/base/OWNERS#newcode33 base/OWNERS:33: per-file BUILD.gn=file://build/OWNERS On 2016/08/24 18:35:19, Nico wrote: > Why should build/OWNERS be owners of base/OWNERS, especially for > Android-specific changes? If you think you should be here, either add ldap, or, > probably better, become a base/android/OWNER? This is just owners of base/BUILD.gn (not OWNERS). I'll see about just becoming an android owner though.
lgtm https://codereview.chromium.org/2271343002/diff/20001/base/android/OWNERS File base/android/OWNERS (right): https://codereview.chromium.org/2271343002/diff/20001/base/android/OWNERS#new... base/android/OWNERS:5: agrieve@chromium.org alphabetical order?
https://codereview.chromium.org/2271343002/diff/20001/base/android/OWNERS File base/android/OWNERS (right): https://codereview.chromium.org/2271343002/diff/20001/base/android/OWNERS#new... base/android/OWNERS:5: agrieve@chromium.org On 2016/08/24 20:51:34, nyquist wrote: > alphabetical order? Done.
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org Link to the patchset: https://codereview.chromium.org/2271343002/#ps40001 (title: "sort")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add agrieve as OWNER for base/android Mainly for proguard and build rules changes. ========== to ========== Add agrieve as OWNER for base/android Mainly for proguard and build rules changes. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add agrieve as OWNER for base/android Mainly for proguard and build rules changes. ========== to ========== Add agrieve as OWNER for base/android Mainly for proguard and build rules changes. Committed: https://crrev.com/6451e6497683be13f366f6c5c196b7a9d2027e71 Cr-Commit-Position: refs/heads/master@{#414264} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6451e6497683be13f366f6c5c196b7a9d2027e71 Cr-Commit-Position: refs/heads/master@{#414264} |
