Issue 227133013: Mojo: Dispatcher::MessageInTransitAccess functions don't need to take the lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227133013: Mojo: Dispatcher::MessageInTransitAccess functions don't need to take the lock. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Dispatcher::MessageInTransitAccess functions don't need to take the lock. It'd be safe for them to take the (Dispatcher) lock, since they're only called when they only have one ref (hence there's no lock ordering issue), but by the same token there's no need for them to take the lock at all. (Also add some comments so that I actually understand this. Maybe I'll even notice these comments the next time I notice this "issue".) R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262256

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	mojo/system/dispatcher.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/system/dispatcher.cc	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	mojo/system/message_in_transit.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/message_pipe_dispatcher.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 8 months ago (2014-04-07 23:52:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r262256 (presubmit successful).

Expand Messages | Collapse Messages