Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2271313002: Bugfix for cross-origin check (Closed)

Created:
4 years, 4 months ago by hubbe
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bugfix for cross-origin check The code is mistaking a missing reader for an error, but readers are now destroyed and re-created on demand. Adding a new variable to explicitly track failures fixes the problem. BUG=639690 Committed: https://crrev.com/5f8b274cdab547c8afff5429110a97d15353c19c Cr-Commit-Position: refs/heads/master@{#414218}

Patch Set 1 #

Patch Set 2 : test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M media/blink/multibuffer_data_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
hubbe
4 years, 4 months ago (2016-08-24 17:38:45 UTC) #3
DaleCurtis
lgtm, unit test?
4 years, 4 months ago (2016-08-24 17:40:18 UTC) #5
hubbe
Test added.
4 years, 4 months ago (2016-08-24 18:05:19 UTC) #8
DaleCurtis
lgtm
4 years, 4 months ago (2016-08-24 18:07:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271313002/20001
4 years, 4 months ago (2016-08-24 18:24:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129029)
4 years, 4 months ago (2016-08-24 19:49:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271313002/20001
4 years, 4 months ago (2016-08-24 20:46:19 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 00:29:16 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:31:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f8b274cdab547c8afff5429110a97d15353c19c
Cr-Commit-Position: refs/heads/master@{#414218}

Powered by Google App Engine
This is Rietveld 408576698