cc : Remove DCHECK in TransformTree::ComputeTranslation

cc : Remove DCHECK in TransformTree::ComputeTranslation

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/3c5633df9d4176f622a9a234e3add677da92dd20
Cr-Commit-Position: refs/heads/master@{#414227}

[jaydasika, 2016-08-24 19:31:29]

Description was changed from

==========
cc : Remove DCHECK in TransformTree::ComputeTranslation

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
==========

to

==========
cc : Remove DCHECK in TransformTree::ComputeTranslation

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-24 19:34:41]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-08-24 19:34:41]

PTAL

[jaydasika, 2016-08-24 19:34:52]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 19:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:13:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ajuma, 2016-08-24 21:40:15]

lgtm

[jaydasika, 2016-08-24 21:47:09]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 21:47:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:00:39]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jaydasika, 2016-08-24 23:01:33]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-08-24 23:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2271273003/#ps40001
(title: "setDouble again")

[commit-bot: I haz the power, 2016-08-24 23:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:39:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 00:42:53]

Description was changed from

==========
cc : Remove DCHECK in TransformTree::ComputeTranslation

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Remove DCHECK in TransformTree::ComputeTranslation

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/3c5633df9d4176f622a9a234e3add677da92dd20
Cr-Commit-Position: refs/heads/master@{#414227}
==========

[commit-bot: I haz the power, 2016-08-25 00:42:54]

Patchset 3 (id:??) landed as
https://crrev.com/3c5633df9d4176f622a9a234e3add677da92dd20
Cr-Commit-Position: refs/heads/master@{#414227}

[Alexander Potapenko, 2016-08-25 09:43:28]

glider@chromium.org changed reviewers:
+ glider@chromium.org

[Alexander Potapenko, 2016-08-25 09:43:29]

https://codereview.chromium.org/2271273003/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2271273003/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:9353:
TEST_F(LayerTreeHostCommonTest, NoisyTransform) {
Did you intend to submit this test as well?

[jaydasika, 2016-08-26 17:39:32]

https://codereview.chromium.org/2271273003/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2271273003/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:9353:
TEST_F(LayerTreeHostCommonTest, NoisyTransform) {
On 2016/08/25 09:43:28, Alexander Potapenko wrote:
> Did you intend to submit this test as well?

Yes. To ensure that no one adds back the DCHECK this CL removes.