Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2271273002: GN: Fuchsia probably cannot link without this. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Fuchsia probably cannot link without this. We removed this _none variant globally, thinking we'd put back platform specific versions as we added support for those platforms. We don't have anything for Fuchsia. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271273002 Committed: https://skia.googlesource.com/skia/+/2ff47c2390814df165234ab16b83dbacf97f1c0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
We don't really have a way to test this.
4 years, 4 months ago (2016-08-24 16:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271273002/1
4 years, 4 months ago (2016-08-24 16:38:11 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 4 months ago (2016-08-24 16:38:12 UTC) #6
bsalomon
lgtm
4 years, 4 months ago (2016-08-24 17:26:21 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 17:27:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ff47c2390814df165234ab16b83dbacf97f1c0f

Powered by Google App Engine
This is Rietveld 408576698