Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/barback/test/transformer/declaring_rewrite.dart

Issue 227123007: Only run [declareOutputs] once for each asset/transformer pair. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/test/transformer/declaring_bad.dart ('k') | pkg/barback/test/transformer/emit_nothing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/transformer/declaring_rewrite.dart
diff --git a/pkg/barback/test/transformer/lazy_rewrite.dart b/pkg/barback/test/transformer/declaring_rewrite.dart
similarity index 62%
copy from pkg/barback/test/transformer/lazy_rewrite.dart
copy to pkg/barback/test/transformer/declaring_rewrite.dart
index f694a0e77da6fd95176075593ed1be8179661b34..063ebbe1d33787667bae716049fa9a6c32f58292 100644
--- a/pkg/barback/test/transformer/lazy_rewrite.dart
+++ b/pkg/barback/test/transformer/declaring_rewrite.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library barback.test.transformer.lazy_rewrite;
+library barback.test.transformer.declaring_rewrite;
import 'dart:async';
@@ -10,17 +10,16 @@ import 'package:barback/barback.dart';
import 'rewrite.dart';
-/// Like [RewriteTransformer], but returns a lazy asset that doesn't perform the
-/// rewrite until it's materialized.
-class LazyRewriteTransformer extends RewriteTransformer
+/// Like [RewriteTransformer], but declares its assets ahead of time.
+class DeclaringRewriteTransformer extends RewriteTransformer
implements LazyTransformer {
- LazyRewriteTransformer(String from, String to)
+ DeclaringRewriteTransformer(String from, String to)
: super(from, to);
Future declareOutputs(DeclaringTransform transform) {
if (consumePrimary) transform.consumePrimary();
for (var extension in to.split(" ")) {
- var id = transform.primaryInput.id.changeExtension(".$extension");
+ var id = transform.primaryId.changeExtension(".$extension");
transform.declareOutput(id);
}
}
« no previous file with comments | « pkg/barback/test/transformer/declaring_bad.dart ('k') | pkg/barback/test/transformer/emit_nothing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698