Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html

Issue 2271223002: Convert LayoutTests/svg/dom/SVGLength*.html js-tests.js tests to testharness.js based tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/svg/dom/SVGLength.html ('K') | « third_party/WebKit/LayoutTests/svg/dom/SVGLength-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGLength-px-expected.txt » ('j') | third_party/WebKit/LayoutTests/svg/dom/SVGLength-px-with-context.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html
diff --git a/third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html b/third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html
index 592427a7fb82a26877cdee4d548af380c7bb759c..f4c82630d573110b13a25d2fed518d40ab27309c 100644
--- a/third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html
+++ b/third_party/WebKit/LayoutTests/svg/dom/SVGLength-px.html
@@ -1,11 +1,130 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test.js"></script>
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script src="script-tests/SVGLength-px.js"></script>
-</body>
-</html>
+<!DOCTYPE HTML>
+<title>Checks SVGLength - converting from px to all other unit types</title>
fs 2016/08/25 10:16:51 'SVGLength, converting from 'px' to other units (d
Shanmuga Pandi 2016/08/26 07:35:18 Done.
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<p></p>
fs 2016/08/25 10:16:51 Per below we don't need this.
Shanmuga Pandi 2016/08/26 07:35:18 Done.
+<script>
+function calculateDPI() {
+ // Crude hack to determine the DPI, instead of hardcoding our 96 dpi here.
fs 2016/08/25 10:16:51 Actually, I think hardcoding 96 is exactly what we
Shanmuga Pandi 2016/08/26 07:35:18 Done.
+ var divElement = document.createElement("div");
+ divElement.setAttribute("style", "height: 1in");
+ var pElement = document.querySelector("p");
+ pElement.appendChild(divElement);
+ var cssPixelsPerInch = divElement.offsetHeight;
+ pElement.removeChild(divElement);
+
+ // Crude hack to make this test pass with Opera/Mac
+ if (navigator.userAgent.indexOf("Opera") != -1) {
+ if (navigator.userAgent.indexOf("Macintosh") != -1) {
+ cssPixelsPerInch = 72;
+ }
+ }
+
+ return cssPixelsPerInch;
+}
+
+test(function() {
fs 2016/08/25 10:16:51 It'd probably make sense to split this into severa
Shanmuga Pandi 2016/08/26 07:35:18 Done.
+ var cssPixelsPerInch = calculateDPI();
+ var svgElement = document.createElementNS("http://www.w3.org/2000/svg", "svg");
+ var length = svgElement.createSVGLength();
+
+ // Set value to be 2px
+ length.valueAsString = "2px";
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PX);
+ assert_equals(length.value, 2);
+ assert_equals(length.valueInSpecifiedUnits, 2);
+ assert_equals(length.valueAsString, "2px");
+
+ // Convert from px to unitless
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_NUMBER);
+ assert_equals(length.valueAsString, "2");
+ assert_equals(length.value, 2);
+ assert_equals(length.valueInSpecifiedUnits, 2);
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_NUMBER);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Try converting from px to percentage, should fail as the SVGLength is not associated with a SVGSVGElement, and thus no viewport information is available
+ assert_throws(null, function() { length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_PERCENTAGE); });
fs 2016/08/25 10:16:51 NotSupportedError
Shanmuga Pandi 2016/08/26 07:35:18 Done.
+ assert_equals(length.valueAsString, "2px");
+ assert_equals(length.value, 2);
+ assert_equals(length.valueInSpecifiedUnits, 2);
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PX);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Try converting from px to ems, should fail as the SVGLength is not associated with a SVGSVGElement, and thus no font-size information is available
+ assert_throws(null, function() { length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_EMS); });
fs 2016/08/25 10:16:51 NotSupportedError
+ assert_equals(length.valueAsString, "2px");
+ assert_equals(length.value, 2);
+ assert_equals(length.valueInSpecifiedUnits, 2);
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PX);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Try converting from px to exs, should fail as the SVGLength is not associated with a SVGSVGElement, and thus no font-size information is available
+ assert_throws(null, function() { length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_EXS); });
fs 2016/08/25 10:16:52 NotSupportedError
+ assert_equals(length.valueAsString, "2px");
+ assert_equals(length.value, 2);
+ assert_equals(length.valueInSpecifiedUnits, 2);
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PX);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Convert from px to cm
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_CM);
+ referenceValue = Number(2 * 2.54 / cssPixelsPerInch).toFixed(7);
+ assert_equals(length.valueAsString, referenceValue + "cm");
+ assert_equals(length.valueInSpecifiedUnits.toFixed(7), referenceValue);
+ assert_equals(length.value.toFixed(1), "2.0");
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_CM);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Convert from px to mm
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_MM);
+ referenceValue = Number(2 * 25.4 / cssPixelsPerInch).toFixed(6);
+ assert_equals(length.valueAsString, referenceValue + "mm");
+ assert_equals(length.valueInSpecifiedUnits.toFixed(6), referenceValue);
+ assert_equals(length.value.toFixed(1), "2.0");
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_MM);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Convert from px to in
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_IN);
+ referenceValue = Number(2 / cssPixelsPerInch).toFixed(7);
+ assert_equals(length.valueAsString, referenceValue + "in");
+ assert_equals(length.valueInSpecifiedUnits.toFixed(7), referenceValue);
+ assert_equals(length.value.toFixed(1), "2.0");
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_IN);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Convert from px to pt
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_PT);
+ referenceValue = Number(2 / cssPixelsPerInch * 72);
+ assert_equals(length.valueAsString, referenceValue + "pt");
+ assert_equals(length.valueInSpecifiedUnits, referenceValue);
+ assert_equals(length.value.toFixed(1), "2.0");
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PT);
+
+ // Reset to 2px
+ length.valueAsString = "2px";
+
+ // Convert from px to pc
+ length.convertToSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_PC);
+ referenceValue = Number(2 / cssPixelsPerInch * 6).toFixed(3);
+ // Don't check valueAsString here, it's unreliable across browsers.
+ assert_equals(length.valueInSpecifiedUnits.toFixed(3), referenceValue);
+ assert_equals(length.value.toFixed(1), "2.0");
+ assert_equals(length.unitType, SVGLength.SVG_LENGTHTYPE_PC);
+});
+</script>
« third_party/WebKit/LayoutTests/svg/dom/SVGLength.html ('K') | « third_party/WebKit/LayoutTests/svg/dom/SVGLength-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGLength-px-expected.txt » ('j') | third_party/WebKit/LayoutTests/svg/dom/SVGLength-px-with-context.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698