Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2271203004: Tweak |in_blink_namespace|, to look at ancestors *and also* at qualifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-same-type-and-method-name
Patch Set: Using hasTopLevelPrefix instead of hasPrefix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index d45e27b52f00f7638a9b42b9cd4781887436faa5..734d7593761f234fead4c2801fb5791de7498b3b 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -210,3 +210,25 @@ void F2() {
WTF::StructInWTF w;
w.function();
}
+
+namespace blink {
+
+class ClassDeclaredInsideBlink {
+ public:
+ static void methodDefinedOutsideBlink();
+};
+
+namespace internal {
+
+class InternalClass {
+ public:
+ static void method();
+};
+
+} // namespace internal
+
+} // namespace blink
+
+// https://crbug.com/640688 - need to rewrite method name below.
+void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
+void blink::internal::InternalClass::method() {}
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698