tools/clang/rewrite_to_chrome_style/tests/functions-original.cc - Issue 2271203004: Tweak |in_blink_namespace|, to look at ancestors *and also* at qualifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

Issue 2271203004: Tweak |in_blink_namespace|, to look at ancestors *and also* at qualifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-same-type-and-method-name

Patch Set: Using hasTopLevelPrefix instead of hasPrefix. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/functions-expected.cc ('k') | tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

index 14530c6570af943f1a6321c360e97ce1bc7fef05..eb5e0ecbde75ffaf699e7275f6747895ebff304e 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

@@ -36,8 +36,15 @@ void F() {

int (*functionPointer)(int, int) = &testFunctionThatTakesTwoInts;

}

+void bug640688(int); // Declaration within blink namespace.

} // namespace blink

+// Definition outside of blink namespace.

+void blink::bug640688(int myParam) {

+ char myVariable = 'c';

using blink::testFunctionThatTakesTwoInts;

void G() {