Files app: Make the warning banner about local space dismissable.

Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than 1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from 36 hours to 10 seconds.

Committed: https://crrev.com/214729817d1ef92f27929c090a962f633b1e5716
Cr-Commit-Position: refs/heads/master@{#414379}

[fukino, 2016-08-24 12:25:09]

Description was changed from

==========
Files app: Make the warning banner about local space dismissable.

BUG=634207
==========

to

==========
Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user
dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than
1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from
36 hours to 10 seconds.
==========

[fukino, 2016-08-24 12:26:13]

fukino@chromium.org changed reviewers:
+ yamaguchi@chromium.org

[fukino, 2016-08-24 12:26:14]

Could you take a look? Thanks!

[yamaguchi, 2016-08-25 05:33:00]

https://codereview.chromium.org/2271203002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/banners.js (right):

https://codereview.chromium.org/2271203002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/banners.js:109: * If the warning
was dismissed before, this key stores the moment of dismissal.
Can we add that "the moment" is in milliseconds since the epoch of the local
system clock, or so on?

[fukino, 2016-08-25 08:28:23]

Thanks!

I updated the comment, and I put a margin for the warning message not to overlap
with the dismiss button.
Could you take another look?

https://codereview.chromium.org/2271203002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/banners.js (right):

https://codereview.chromium.org/2271203002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/banners.js:109: * If the warning
was dismissed before, this key stores the moment of dismissal.
On 2016/08/25 05:33:00, yamaguchi wrote:
> Can we add that "the moment" is in milliseconds since the epoch of the local
> system clock, or so on?

Done.

[yamaguchi, 2016-08-25 09:06:00]

lgtm

I think the overlap can be avoided more simply if the elements are placed as
flexbox (instead of absolute position), but since the close button is also used
by other banners, this would be a reasonable fix minimizing the change.

[fukino, 2016-08-25 09:07:54]

Thanks!

The overall implementation of banners could be simplified. Let's do it in spare
time for the next milestone :)

[fukino, 2016-08-25 09:08:00]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:08:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 10:00:31]

Description was changed from

==========
Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user
dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than
1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from
36 hours to 10 seconds.
==========

to

==========
Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user
dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than
1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from
36 hours to 10 seconds.
==========

[commit-bot: I haz the power, 2016-08-25 10:00:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 10:02:03]

Description was changed from

==========
Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user
dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than
1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from
36 hours to 10 seconds.
==========

to

==========
Files app: Make the warning banner about local space dismissable.

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user
dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than
1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from
36 hours to 10 seconds.

Committed: https://crrev.com/214729817d1ef92f27929c090a962f633b1e5716
Cr-Commit-Position: refs/heads/master@{#414379}
==========

[commit-bot: I haz the power, 2016-08-25 10:02:04]

Patchset 2 (id:??) landed as
https://crrev.com/214729817d1ef92f27929c090a962f633b1e5716
Cr-Commit-Position: refs/heads/master@{#414379}