chrome/common/extensions/docs/templates/articles/nativeMessaging.html - Issue 2271143002: Ensure/document that the first parameter to the native messaging host is the origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/templates/articles/nativeMessaging.html

Issue 2271143002: Ensure/document that the first parameter to the native messaging host is the origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify parameters on Windows Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher.cc ('k') | chrome/test/data/native_messaging/native_hosts/echo.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/templates/articles/nativeMessaging.html

diff --git a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

index c3f2cb00b3f5e7d1714872093835f90dcf9b0698..3a1f94d493318ac809fc8e094a2c858405609d25 100644

--- a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

+++ b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

@@ -129,6 +129,16 @@ mainly to protect Chrome from misbehaving native applications. The maximum

size of the message sent to the native messaging host is 4 GB.

+The first argument to the native messaging host is the origin of the caller,

+usually <code>chrome-extension://[ID of whitelisted extension]</code>.

+This allows native messaging hosts to identify the source of the message when

+multiple extensions are specified in the <code>allowed_origins</code> key in the

+<a href="#native-messaging-host-manifest">native messaging host manifest</a>.

+

+Warning: In Windows, in Chrome 54 and earlier, the origin was

+passed as the second parameter instead of the first parameter.

+

When a messaging port is created using $(ref:runtime.connectNative) Chrome

starts native messaging host process and keeps it running until the port is

destroyed. On the other hand, when a message is sent using

@@ -140,7 +150,7 @@ $(ref:runtime.sendNativeMessage) is called. All other messages generated by the

native messaging host in that case are ignored.

-On Windows, the native messaging host gets passed a command line argument with

+On Windows, the native messaging host is also passed a command line argument with

a handle to the calling chrome native window: <code>--parent-window=&ltdecimal

handle value&gt</code>. This lets the native messaging host create native UI

windows that are correctly focused.