chrome/common/extensions/docs/templates/articles/nativeMessaging.html - Issue 2271143002: Ensure/document that the first parameter to the native messaging host is the origin

Unified Diff: chrome/common/extensions/docs/templates/articles/nativeMessaging.html

Issue 2271143002: Ensure/document that the first parameter to the native messaging host is the origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure that the origin is really the first arg Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher.cc ('k') | chrome/test/data/native_messaging/native_hosts/echo.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/templates/articles/nativeMessaging.html

diff --git a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

index c3f2cb00b3f5e7d1714872093835f90dcf9b0698..e86a3928b8e8a43fdd0a5d7e51f59c7bebea2744 100644

--- a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

+++ b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html

@@ -129,6 +129,14 @@ mainly to protect Chrome from misbehaving native applications. The maximum

size of the message sent to the native messaging host is 4 GB.

<p>

+The first argument to the native messaging host is the origin of the caller,

+usually <code>chrome-extension://[extension ID of whitelisted extension]</code>.

Devlin 2016/09/26 15:53:59 nit: s/extension ID of whitelisted extension/ID of

robwu 2016/09/28 09:07:09 Done.

+This allows native messaging hosts to identify the source of the message when it

+has allowed multiple extensions to use the native messaging host via the

+<code>allowed_origins</code> key in the

+<a href="#native-messaging-host-manifest">native messaging host manifest</a>.

Devlin 2016/09/26 15:53:59 This sentence reads a little funny. Maybe "This

robwu 2016/09/28 09:07:09 SGTM. I used "native messaging host manifest" inst

+<p>

When a messaging port is created using $(ref:runtime.connectNative) Chrome

starts native messaging host process and keeps it running until the port is

destroyed. On the other hand, when a message is sent using