Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

Issue 2271133002: WebSocket: Stop Bridge::disconnect() from waiting until Peer::disconnect() is complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
index 5274c4c6599493c2dd24921c301a8afcf50ff15b..4e190446955c8c5a4e074def1936ed0de691787e 100644
--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
@@ -89,7 +89,7 @@ public:
USING_GARBAGE_COLLECTED_MIXIN(Peer);
WTF_MAKE_NONCOPYABLE(Peer);
public:
- Peer(Bridge*, PassRefPtr<WorkerLoaderProxy>, WebSocketChannelSyncHelper*, WorkerThreadLifecycleContext*);
+ Peer(Bridge*, PassRefPtr<WorkerLoaderProxy>, WorkerThreadLifecycleContext*);
~Peer() override;
// SourceLocation parameter may be shown when the connection fails.
@@ -123,7 +123,6 @@ public:
CrossThreadWeakPersistent<Bridge> m_bridge;
RefPtr<WorkerLoaderProxy> m_loaderProxy;
Member<WebSocketChannel> m_mainWebSocketChannel;
- Member<WebSocketChannelSyncHelper> m_syncHelper;
};
// Bridge for Peer. Running on the worker thread.
@@ -143,7 +142,7 @@ public:
void fail(const String& reason, MessageLevel, std::unique_ptr<SourceLocation>);
void disconnect();
- void connectOnMainThread(std::unique_ptr<SourceLocation>, WorkerThreadLifecycleContext*, const KURL&, const String& protocol, ExecutionContext*);
+ void connectOnMainThread(std::unique_ptr<SourceLocation>, WorkerThreadLifecycleContext*, const KURL&, const String& protocol, WebSocketChannelSyncHelper*, ExecutionContext*);
// Returns null when |disconnect| has already been called.
WebSocketChannelClient* client() { return m_client; }
@@ -153,13 +152,9 @@ public:
EAGERLY_FINALIZE();
private:
- // Returns false if shutdown event is received before method completion.
- bool waitForMethodCompletion(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>);
-
Member<WebSocketChannelClient> m_client;
Member<WorkerGlobalScope> m_workerGlobalScope;
RefPtr<WorkerLoaderProxy> m_loaderProxy;
- Member<WebSocketChannelSyncHelper> m_syncHelper;
CrossThreadPersistent<Peer> m_peer;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698