Expose the virtual memory limit to blink

Expose the virtual memory limit to blink

V8 queries the limit before sandbox initialization via static
initializers. We should pass it in like the other memory related values
instead.

BUG=none
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262544

[Mark Mentovai, 2014-04-08 18:49:56]

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h
File base/sys_info.h (right):

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h#newcode41
base/sys_info.h:41: // Return the number of megabtesof available virtual memory,
or zero if it is
megabtesof

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h#newcode43
base/sys_info.h:43: static int AmountOfVirtualMemoryMB() {
I don’t think there’s really any precedent for having both an Xxx and XxxMB call
available. Nothing else in here does that.

https://codereview.chromium.org/227113011/diff/1/base/sys_info_posix.cc
File base/sys_info_posix.cc (right):

https://codereview.chromium.org/227113011/diff/1/base/sys_info_posix.cc#newco...
base/sys_info_posix.cc:52: if (result != 0) return 0;
It’s a little weird to use 0 for both the failure case and the unlimited case.

[jochen (gone - plz use gerrit), 2014-04-08 19:26:31]

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h
File base/sys_info.h (right):

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h#newcode41
base/sys_info.h:41: // Return the number of megabtesof available virtual memory,
or zero if it is
On 2014/04/08 18:49:57, Mark Mentovai wrote:
> megabtesof

Done.

https://codereview.chromium.org/227113011/diff/1/base/sys_info.h#newcode43
base/sys_info.h:43: static int AmountOfVirtualMemoryMB() {
On 2014/04/08 18:49:57, Mark Mentovai wrote:
> I don’t think there’s really any precedent for having both an Xxx and XxxMB
call
> available. Nothing else in here does that.

see line 37. I don't care either way

https://codereview.chromium.org/227113011/diff/1/base/sys_info_posix.cc
File base/sys_info_posix.cc (right):

https://codereview.chromium.org/227113011/diff/1/base/sys_info_posix.cc#newco...
base/sys_info_posix.cc:52: if (result != 0) return 0;
On 2014/04/08 18:49:57, Mark Mentovai wrote:
> It’s a little weird to use 0 for both the failure case and the unlimited case.

this call should never fail. I can add NOTREACHED();

[Mark Mentovai, 2014-04-08 19:33:56]

Hmm, OK, so there is precedent. OK, it’ll be inlined and result in the same
object code either way, so LGTM as-is now.

[jochen (gone - plz use gerrit), 2014-04-08 19:38:42]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-04-08 19:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/227113011/20001

[commit-bot: I haz the power, 2014-04-08 23:19:25]

Change committed as 262544