Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 227113005: Make `String.prototype.contains` throw when passing a regular expression (Closed)

Created:
6 years, 8 months ago by mathiasb
Modified:
6 years, 8 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Make `String.prototype.contains` throw when passing a regular expression Contributed by Mathias Bynens <mathiasb@opera.com>;. TEST=mjsunit/harmony BUG=v8:3261 LOG=Y R=yangguo@chromium.org, arv@chromium.org, ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20534

Patch Set 1 #

Patch Set 2 : Fix test-mark-compact/BootUpMemoryUse on x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M src/harmony-string.js View 3 chunks +9 lines, -3 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/string-contains.js View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mathiasb
6 years, 8 months ago (2014-04-06 20:30:57 UTC) #1
Yang
On 2014/04/06 20:30:57, mathiasb wrote: LGTM
6 years, 8 months ago (2014-04-07 06:36:16 UTC) #2
Yang
On 2014/04/07 06:36:16, Yang wrote: > On 2014/04/06 20:30:57, mathiasb wrote: > > LGTM test-mark-compact/BootUpMemoryUse ...
6 years, 8 months ago (2014-04-07 06:46:27 UTC) #3
mathiasb
> test-mark-compact/BootUpMemoryUse fails on x64 bit. Could you bump up the limits > there for ...
6 years, 8 months ago (2014-04-07 09:07:35 UTC) #4
Yang
Committed patchset #2 manually as r20534 (presubmit successful).
6 years, 8 months ago (2014-04-07 10:24:08 UTC) #5
arv (Not doing code reviews)
6 years, 8 months ago (2014-04-07 15:34:20 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698