Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2271123002: Oops - set the master field to an empty string. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Oops - set the master field to an empty string. This is still required while we transition off the old metrics sent by mastermon, although in future its value will be taken from job_name. BUG=620610 TBR=sergeyberezin Committed: https://chromium.googlesource.com/chromium/tools/build/+/9a32053af884abbc8f9ea6a77df8a362cc0be1f6

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : Oops again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M scripts/master/monitoring_status_receiver.py View 1 2 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dsansome
4 years, 4 months ago (2016-08-24 06:42:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271123002/40001
4 years, 4 months ago (2016-08-24 06:47:35 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 06:51:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/9a32053af884abbc8f9e...

Powered by Google App Engine
This is Rietveld 408576698