Accept any string for currency code in PaymentRequest.

third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentsValidators.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/text/WTFString.h"
 #include <ostream> // NOLINT
 
@@ skipping 14 matching lines @@
 
 std::ostream& operator<<(std::ostream& out, const TestCase& testCase)
 {
     out << "'" << testCase.input << "' is expected to be " << (testCase.expectedValid ? "valid" : "invalid");
     return out;
 }
 
 class PaymentsCurrencyValidatorTest : public testing::TestWithParam<TestCase> {
 };
 
+const char* longString2048()
+{
+    static char longString[2049];
+    for (int i = 0; i < 2049; i++)

[please use gerrit instead, 2016/08/25 16:47:38]

i < 2048

[pals, 2016/08/26 07:20:26]

One extra space for '\0'. strlen() does not include '\0'.

[please use gerrit instead, 2016/08/26 17:01:37]

In the current state, the last value if "i" is "2048". The last operation of the
for-loop is

longString[2048] = 'a';

However, on the next line you overwrite this value immediately:

longString[2048] = '\0';

It's not a matter of efficiency, but it's strange to write to the same location
twice in a row.

[pals, 2016/08/27 11:16:31]

I'm sorry. You are correct. Rectified the issue.

+        longString[i] = 'a';
+    longString[2048] = '\0';
+    return longString;
+}
+
+const char* longString2049()
+{
+    static char longString[2050];
+    for (int i = 0; i < 2050; i++)

[please use gerrit instead, 2016/08/25 16:47:38]

i < 2049

[pals, 2016/08/26 07:20:26]

Same reason.

+        longString[i] = 'a';
+    longString[2049] = '\0';
+    return longString;
+}
+
 TEST_P(PaymentsCurrencyValidatorTest, IsValidCurrencyCodeFormat)
 {
     String errorMessage;
     EXPECT_EQ(GetParam().expectedValid, PaymentsValidators::isValidCurrencyCodeFormat(GetParam().input, &errorMessage)) << errorMessage;
     EXPECT_EQ(GetParam().expectedValid, errorMessage.isEmpty()) << errorMessage;
 
     EXPECT_EQ(GetParam().expectedValid, PaymentsValidators::isValidCurrencyCodeFormat(GetParam().input, nullptr));
 }
 
 INSTANTIATE_TEST_CASE_P(CurrencyCodes,
     PaymentsCurrencyValidatorTest,
     testing::Values(
+        // Any string can be a currency code
         TestCase("USD", true),
-        // Invalid currency code formats
-        TestCase("US1", false),
-        TestCase("US", false),
-        TestCase("USDO", false),
-        TestCase("usd", false),
-        TestCase("", false)));
+        TestCase("US1", true),
+        TestCase("US", true),
+        TestCase("USDO", true),
+        TestCase("usd", true),
+        TestCase("ANYSTRING", true),
+        TestCase("", true),
+        TestCase(longString2048(), true),
+        TestCase(longString2049(), false)));
 
 class PaymentsAmountValidatorTest : public testing::TestWithParam<TestCase> {
 };
 
 TEST_P(PaymentsAmountValidatorTest, IsValidAmountFormat)
 {
     String errorMessage;
     EXPECT_EQ(GetParam().expectedValid, PaymentsValidators::isValidAmountFormat(GetParam().input, &errorMessage)) << errorMessage;
     EXPECT_EQ(GetParam().expectedValid, errorMessage.isEmpty()) << errorMessage;
 
@@ skipping 144 matching lines @@
         ShippingAddressTestCase("US", "", "", true),
         // Invalid shipping addresses
         ShippingAddressTestCase("", "", "", false),
         ShippingAddressTestCase("InvalidCountryCode", "", "", false),
         ShippingAddressTestCase("US", "InvalidLanguageCode", "", false),
         ShippingAddressTestCase("US", "en", "InvalidScriptCode", false),
         ShippingAddressTestCase("US", "", "Latn", false)));
 
 } // namespace
 } // namespace blink