Accept any string for currency code in PaymentRequest.

chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments.ui;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Color;
 import android.graphics.Typeface;
@@ skipping 510 matching lines @@
      * .................................................................| CHERVON .
      * . LEFT SUMMARY TEXT                        |  RIGHT SUMMARY TEXT |    or   .
      * .................................................................|   ADD   .
      * .                                      | Line item 1 |    $13.99 |    or   .
      * .                                      | Line item 2 |      $.99 |  SELECT .
      * .                                      | Line item 3 |     $2.99 |         .
      * ............................................................................
      */
     public static class LineItemBreakdownSection extends PaymentRequestSection {
         private GridLayout mBreakdownLayout;
+        private static final int MAX_CURRENCY_CHARS = 6;
+        private static final String ELLIPSIS = "...";

[please use gerrit instead, 2016/08/25 16:47:38]

Use the unicode ellipsis character:
http://www.fileformat.info/info/unicode/char/2026/index.htm

[pals, 2016/08/26 07:20:26]

If it is ok, I'll do the application related changes as a follow up patch?

[please use gerrit instead, 2016/08/26 17:01:37]

OK. Since Samsung does not use Chromium's UI (as far as I know), you don't have
to modify the UI code aside from making it compile and making sure that all
tests pass. I can take care of making it look good.

[pals, 2016/08/27 11:16:31]

I'm working on it here https://codereview.chromium.org/2281913002/.

 
         public LineItemBreakdownSection(
                 Context context, String sectionName, SectionDelegate delegate) {
             super(context, sectionName, delegate);
         }
 
         @Override
         protected void createMainSectionContent(LinearLayout mainSectionLayout) {
             Context context = mainSectionLayout.getContext();
 
@@ skipping 57 matching lines @@
         /**
          * Builds a CharSequence that displays a value in a particular currency.
          *
          * @param currency    Currency of the value being displayed.
          * @param value       Value to display.
          * @param isValueBold Whether or not to bold the item.
          * @return CharSequence that represents the whole value.
          */
         private CharSequence createValueString(String currency, String value, boolean isValueBold) {
             SpannableStringBuilder valueBuilder = new SpannableStringBuilder();
+            if (currency.length() > MAX_CURRENCY_CHARS) {

[please use gerrit instead, 2016/08/25 16:47:38]

All currency formatting should happen in CurrencyStringFormatter.java.

+                currency = currency.substring(0, MAX_CURRENCY_CHARS) + ELLIPSIS;

[please use gerrit instead, 2016/08/25 16:47:38]

currency = currency.substring(0, MAX_CURRENCY_CHARS - 1) + ELLIPSIS;

That way a 7 character currency is truncated into 5 characters + ellipsis. (If
you have enough space to show 6 characters + ellipsis, then might as well just
show the full 7 characters.)

+            }
             valueBuilder.append(currency);
             valueBuilder.append(" ");
 
             int boldStartIndex = valueBuilder.length();
             valueBuilder.append(value);
 
             if (isValueBold) {
                 valueBuilder.setSpan(new StyleSpan(android.graphics.Typeface.BOLD), boldStartIndex,
                         boldStartIndex + value.length(), 0);
             }
@@ skipping 527 matching lines @@
         }
 
         /** Expand the separator to be the full width of the dialog. */
         public void expand() {
             LinearLayout.LayoutParams params = (LinearLayout.LayoutParams) getLayoutParams();
             ApiCompatibilityUtils.setMarginStart(params, 0);
             ApiCompatibilityUtils.setMarginEnd(params, 0);
         }
     }
 }