Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: src/parsing/preparser.cc

Issue 2271063002: Centralize and standardize logic for ExpressionClassifier accumulation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/preparser.cc
diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc
index 9fa94a362e4085e10b3eba3ef77de059af11b500..6e5698b574d9eaa66060b0b869352ffc5f229621 100644
--- a/src/parsing/preparser.cc
+++ b/src/parsing/preparser.cc
@@ -1176,8 +1176,8 @@ PreParserExpression PreParser::ParseClassLiteral(
CheckNoTailCallExpressions(&extends_classifier, CHECK_OK);
ValidateExpression(&extends_classifier, CHECK_OK);
if (classifier != nullptr) {
- classifier->Accumulate(&extends_classifier,
- ExpressionClassifier::ExpressionProductions);
+ classifier->AccumulateFormalParameterContainmentErrors(
+ &extends_classifier);
}
}
@@ -1197,8 +1197,8 @@ PreParserExpression PreParser::ParseClassLiteral(
&has_seen_constructor, &property_classifier, &name, CHECK_OK);
ValidateExpression(&property_classifier, CHECK_OK);
if (classifier != nullptr) {
- classifier->Accumulate(&property_classifier,
- ExpressionClassifier::ExpressionProductions);
+ classifier->AccumulateFormalParameterContainmentErrors(
+ &property_classifier);
}
}

Powered by Google App Engine
This is Rietveld 408576698