Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: src/parsing/parser.cc

Issue 2271063002: Centralize and standardize logic for ExpressionClassifier accumulation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/expression-classifier.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index 9060868a3ff0e08ec3746221078ae87ad75924d5..1801aea3537f4e129373692b079e583f920e5c83 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -4677,8 +4677,8 @@ Expression* Parser::ParseClassLiteral(ExpressionClassifier* classifier,
CheckNoTailCallExpressions(&extends_classifier, CHECK_OK);
RewriteNonPattern(&extends_classifier, CHECK_OK);
if (classifier != nullptr) {
- classifier->Accumulate(&extends_classifier,
- ExpressionClassifier::ExpressionProductions);
+ classifier->AccumulateFormalParameterContainmentErrors(
+ &extends_classifier);
}
} else {
block_state.set_start_position(scanner()->location().end_pos);
@@ -4706,8 +4706,8 @@ Expression* Parser::ParseClassLiteral(ExpressionClassifier* classifier,
&has_seen_constructor, &property_classifier, &property_name, CHECK_OK);
RewriteNonPattern(&property_classifier, CHECK_OK);
if (classifier != nullptr) {
- classifier->Accumulate(&property_classifier,
- ExpressionClassifier::ExpressionProductions);
+ classifier->AccumulateFormalParameterContainmentErrors(
+ &property_classifier);
}
if (has_seen_constructor && constructor == nullptr) {
« no previous file with comments | « src/parsing/expression-classifier.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698