Convert drawPaint to drawRRect in simple cases

Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004

Committed: https://skia.googlesource.com/skia/+/cb31e51d9355adb1d25ce3e121cde21b05ecf63e

[bsalomon, 2016-08-24 19:43:16]

Description was changed from

==========
hacky drawPaint into drawRRect
==========

to

==========
hacky drawPaint into drawRRect
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004
==========

[bsalomon, 2016-08-26 13:31:00]

Description was changed from

==========
hacky drawPaint into drawRRect
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004
==========

to

==========
Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004
==========

[bsalomon, 2016-08-26 13:31:00]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-08-26 14:00:44]

https://codereview.chromium.org/2271053004/diff/100001/include/core/SkClipSta...
File include/core/SkClipStack.h (right):

https://codereview.chromium.org/2271053004/diff/100001/include/core/SkClipSta...
include/core/SkClipStack.h:371: * @param bounds   A bounds on the geometry that
will be drawn through the clip. The clip only
instersection ?

https://codereview.chromium.org/2271053004/diff/100001/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

https://codereview.chromium.org/2271053004/diff/100001/src/core/SkClipStack.c...
src/core/SkClipStack.cpp:884: SkRect backBounds;
Why isn't backBounds just back's rect? Shouldn't the quick reject test be if
bounds doesn't contain back's rect?

https://codereview.chromium.org/2271053004/diff/100001/src/gpu/GrFixedClip.h
File src/gpu/GrFixedClip.h (right):

https://codereview.chromium.org/2271053004/diff/100001/src/gpu/GrFixedClip.h#...
src/gpu/GrFixedClip.h:47: SkRect rect = SkRect::Make(fScissorState.rect());
not !rtBounds.contains(rect) ?

[bsalomon, 2016-08-26 14:19:18]

Hopefully the docs are clearer now.

https://codereview.chromium.org/2271053004/diff/100001/include/core/SkClipSta...
File include/core/SkClipStack.h (right):

https://codereview.chromium.org/2271053004/diff/100001/include/core/SkClipSta...
include/core/SkClipStack.h:371: * @param bounds   A bounds on the geometry that
will be drawn through the clip. The clip only
On 2016/08/26 14:00:43, robertphillips wrote:
> instersection ?

Done.

[bsalomon, 2016-08-26 14:30:39]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 14:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-26 14:31:54]

lgtm. I think the new comment is better.

[commit-bot: I haz the power, 2016-08-26 14:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 14:40:54]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[robertphillips, 2016-08-26 15:06:24]

Do any of our GMs exercise this?

[bsalomon, 2016-08-26 15:51:49]

On 2016/08/26 15:06:24, robertphillips wrote:
> Do any of our GMs exercise this?

One happened to, but I've now added an explicit GM that tests aa, non-aa, solid
color, shader, and save layer (to exercise offset code in grclipstackclip).

[bsalomon, 2016-08-26 15:53:09]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-08-26 15:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2271053004/#ps180001
(title: "gm comment")

[commit-bot: I haz the power, 2016-08-26 15:53:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:02:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:02:29]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-08-26 17:14:27]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-08-26 17:14:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2271053004/#ps200001
(title: "fix another msvs warning")

[commit-bot: I haz the power, 2016-08-26 17:14:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:48:21]

Description was changed from

==========
Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004
==========

to

==========
Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004

Committed:
https://skia.googlesource.com/skia/+/cb31e51d9355adb1d25ce3e121cde21b05ecf63e
==========

[commit-bot: I haz the power, 2016-08-26 17:48:22]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/cb31e51d9355adb1d25ce3e121cde21b05ecf63e