Settings Router: Restrict navigateToPreviousRoute from going deeper.

Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3e988531f70d2489982275e0fc26e18f8cc6c9ca
Cr-Commit-Position: refs/heads/master@{#414181}

[tommycli, 2016-08-24 00:08:45]

Description was changed from

==========
Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
==========

to

==========
Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-24 00:09:01]

michaelpg: PTAL thanks!!

[michaelpg, 2016-08-24 18:04:32]

i can has test

[tommycli, 2016-08-24 18:07:36]

On 2016/08/24 18:04:32, michaelpg wrote:
> i can has test

u can. I'll write one.

[tommycli, 2016-08-24 18:52:17]

michaelpg: thanks! i added a test

[michaelpg, 2016-08-24 20:25:08]

lgtm

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/route_tests.js (right):

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/route_tests.js:65: function
testNavigateBack(previousRoute, currentRoute,
testNavigateBackUsesHistory

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/route_tests.js:77:
window.addEventListener('popstate', callback);
opt nit: I prefer this pattern without a variable:

window.addEventListener('popstate', function callback() {
  window.removeEventListener('popstate', callback);
  ...
});

[tommycli, 2016-08-24 20:41:36]

michaelpg: thanks!!

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/route_tests.js (right):

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/route_tests.js:65: function
testNavigateBack(previousRoute, currentRoute,
On 2016/08/24 20:25:08, michaelpg wrote:
> testNavigateBackUsesHistory

Done.

https://codereview.chromium.org/2271003003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/route_tests.js:77:
window.addEventListener('popstate', callback);
On 2016/08/24 20:25:08, michaelpg wrote:
> opt nit: I prefer this pattern without a variable:
> 
> window.addEventListener('popstate', function callback() {
>   window.removeEventListener('popstate', callback);
>   ...
> });

Done. Whoa... i didn't even know that was possible.

[tommycli, 2016-08-24 20:41:51]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-24 20:41:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2271003003/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-08-24 20:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:43:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 22:44:49]

Description was changed from

==========
Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router: Restrict navigateToPreviousRoute from going deeper.

Previous routes must now have equal or lesser depth.

BUG=640323
R=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3e988531f70d2489982275e0fc26e18f8cc6c9ca
Cr-Commit-Position: refs/heads/master@{#414181}
==========

[commit-bot: I haz the power, 2016-08-24 22:44:50]

Patchset 3 (id:??) landed as
https://crrev.com/3e988531f70d2489982275e0fc26e18f8cc6c9ca
Cr-Commit-Position: refs/heads/master@{#414181}