Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 22710006: Deprecate self and total time getters and total sample count getter on CpuProfileNode (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Deprecate self and total time getters and total sample count getter on CpuProfileNode All of these values are derived from the self samples count and there is no need to evaluate them in v8 when clients can do that when needed on their side. Also added unsigned GetHitCount() which should be used instead of double GetSelfSamplesCount(). I'm going to deprecate the latter one once Blink has switched to GetHitCount. BUG=267595 TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M include/v8-profiler.h View 1 chunk +11 lines, -4 lines 0 comments Download
M src/api.cc View 6 chunks +5 lines, -14 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
This is exact clone of r16116 which was rolled out in r16117 due to pending ...
7 years, 4 months ago (2013-08-09 07:37:25 UTC) #1
yurys
7 years, 4 months ago (2013-08-09 07:38:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r16119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698