[layoutng] Add an NGFragmentBuilder

third_party/WebKit/Source/core/layout/ng/ng_fragment.h

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
index 5b5c13dd9085ab7f73538633feb68beb428327cb..4913de8f32f8b9319aa7d74369be1c33a7f58506 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
@@ -8,6 +8,7 @@
 #include "core/CoreExport.h"
 #include "core/layout/ng/ng_fragment_base.h"
 #include "core/layout/ng/ng_constraint_space.h"
+#include "core/layout/ng/ng_units.h"
 #include "platform/LayoutUnit.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Vector.h"
@@ -16,31 +17,23 @@ namespace blink {
 
 class CORE_EXPORT NGFragment final : public NGFragmentBase {
  public:
-  NGFragment(LayoutUnit inlineSize,
-             LayoutUnit blockSize,
-             LayoutUnit inlineOverflow,
-             LayoutUnit blockOverflow,
+  NGFragment(NGLogicalSize size,
+             NGLogicalSize overflow,
              NGWritingMode writingMode,
              NGDirection direction)
-      : NGFragmentBase(inlineSize,
-                       blockSize,
-                       inlineOverflow,
-                       blockOverflow,
-                       writingMode,
-                       direction,
-                       FragmentBox) {}
+      : NGFragmentBase(size, overflow, writingMode, direction, FragmentBox) {}
 
   DEFINE_INLINE_TRACE_AFTER_DISPATCH() {
-    visitor->trace(m_children);
+    visitor->trace(children_);
     NGFragmentBase::traceAfterDispatch(visitor);
   }
 
-  void swapChildren(HeapVector<Member<const NGFragmentBase>>& children) {
-    m_children.swap(children);
+  void SwapChildren(HeapVector<Member<const NGFragmentBase>>& children) {

[eae, 2016/08/23 22:10:27]

It would be great if we could move populating the child collection to the
builder too.

+    children_.swap(children);
   }
 
  private:
-  HeapVector<Member<const NGFragmentBase>> m_children;
+  HeapVector<Member<const NGFragmentBase>> children_;
 };
 
 }  // namespace blink