[layoutng] Add an NGFragmentBuilder

[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/ba2f2c86ea8e4b0f6bb744b679396911907b8d6a
Cr-Commit-Position: refs/heads/master@{#414139}

[cbiesinger, 2016-08-23 21:18:09]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-08-23 21:18:46]

Description was changed from

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
==========

to

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
==========

[commit-bot: I haz the power, 2016-08-23 21:19:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 21:23:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[eae, 2016-08-23 22:10:27]

LGTM w/suggestion

https://codereview.chromium.org/2270983002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_fragment.h (right):

https://codereview.chromium.org/2270983002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_fragment.h:31: void
SwapChildren(HeapVector<Member<const NGFragmentBase>>& children) {
It would be great if we could move populating the child collection to the
builder too.

[cbiesinger, 2016-08-24 01:58:09]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 01:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-24 01:59:37]

On 2016/08/23 22:10:27, eae wrote:
> LGTM w/suggestion
> 
>
https://codereview.chromium.org/2270983002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/ng/ng_fragment.h (right):
> 
>
https://codereview.chromium.org/2270983002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/ng/ng_fragment.h:31: void
> SwapChildren(HeapVector<Member<const NGFragmentBase>>& children) {
> It would be great if we could move populating the child collection to the
> builder too.

I now uploaded the missing files, so now this compiles!

I am doing the child population in the builder, but I assume you mean not having
a setter and instead taking it in the constructor? I'll do that tomorrow.

[commit-bot: I haz the power, 2016-08-24 04:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 04:38:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[cbiesinger, 2016-08-24 16:10:04]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:10:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-24 16:12:58]

LGTM

[cbiesinger, 2016-08-24 16:23:06]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-08-24 16:23:11]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:23:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-24 16:24:49]

Thanks!

Also, I considered marking the fragment builder STACK_ALLOCATED but didn't
because I expect once we use the state machine it will have to be a member
variable and be no longer stack allocated.

[commit-bot: I haz the power, 2016-08-24 18:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:07:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[cbiesinger, 2016-08-24 18:10:25]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:11:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-24 20:42:15]

Description was changed from

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
==========

to

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true
==========

[cbiesinger, 2016-08-24 20:42:21]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-08-24 20:42:27]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:43:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:50:21]

Description was changed from

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-24 20:50:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 20:53:21]

Description was changed from

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[layoutng] Add an NGFragmentBuilder

This patch does a few things:
- Adds and uses an NGFragmentBuilder to create fragments
- Code style/variable and function naming cleanup in NGFragment
- Use the structs from ng_units in NGFragment to store sizes

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/ba2f2c86ea8e4b0f6bb744b679396911907b8d6a
Cr-Commit-Position: refs/heads/master@{#414139}
==========

[commit-bot: I haz the power, 2016-08-24 20:53:22]

Patchset 3 (id:??) landed as
https://crrev.com/ba2f2c86ea8e4b0f6bb744b679396911907b8d6a
Cr-Commit-Position: refs/heads/master@{#414139}