Make skia recipes explicitly set GIT_MODE

Make skia recipes explicitly set GIT_MODE

R=borenet@chromium.org, iannucci@chromium.org
BUG=640251
Committed: https://chromium.googlesource.com/chromium/tools/build/+/a6d4645baf26287ae6c0870a1206624bfa59fd83

[borenet2, 2016-08-24 11:42:45]

https://codereview.chromium.org/2270963002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/skia/api.py (right):

https://codereview.chromium.org/2270963002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/skia/api.py:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
FTR almost all of this now lives in the Skia repo:
https://skia.googlesource.com/skia/+/master/infra/bots/recipe_modules
and
https://skia.googlesource.com/skia/+/master/infra/bots/recipes

I've waited to remove it for backwards compatibility in case of building old
code.

https://codereview.chromium.org/2270963002/diff/1/scripts/slave/recipes/skia/...
File scripts/slave/recipes/skia/ct_skps.expected/CT_CPU_BENCH_10k_SKPs.json
(right):

https://codereview.chromium.org/2270963002/diff/1/scripts/slave/recipes/skia/...
scripts/slave/recipes/skia/ct_skps.expected/CT_CPU_BENCH_10k_SKPs.json:87:
"cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed':
False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'},
{'deps_file': '.DEPS.git', 'managed': False, 'name': 'src', 'url':
'https://chromium.googlesource.com/chromium/src.git'}]"
So... there's no .DEPS.git file in Skia.  Will this work properly?

[borenet2, 2016-08-24 11:43:09]

(LGTM if the DEPS file will be correct)

[agable, 2016-08-24 16:20:48]

Yeah, I hate the .DEPS.git thing too. It should go away soon, along with the
rest of our svn artifacts. In the mean time, though, gclient always falls back
to 'DEPS' if it can't find the specified file:
https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?q=file:depot_to...

[agable, 2016-08-24 16:22:16]

Oh, I had no idea about the recipes in the skia repo. Does the recipe autoroller
roll into the skia repo? If so, I (or you) will have to make the equivalent
changes there as well.

[agable, 2016-08-24 16:22:24]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:26:59]

Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d62fbbb86f2f10)

[borenet, 2016-08-24 16:40:36]

On 2016/08/24 16:22:16, agable wrote:
> Oh, I had no idea about the recipes in the skia repo. Does the recipe
autoroller
> roll into the skia repo? If so, I (or you) will have to make the equivalent
> changes there as well.

No, we're not opted into the autoroller yet, since the commit rate is still
pretty high.  We do a manual roll about every week or so.

[agable, 2016-08-24 16:46:28]

The CQ bit was checked by agable@chromium.org

[agable, 2016-08-24 16:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@chromium.org
Link to the patchset: https://codereview.chromium.org/2270963002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-24 16:46:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:51:18]

Description was changed from

==========
Make skia recipes explicitly set GIT_MODE

R=borenet@chromium.org, iannucci@chromium.org
BUG=640251
==========

to

==========
Make skia recipes explicitly set GIT_MODE

R=borenet@chromium.org, iannucci@chromium.org
BUG=640251

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/a6d4645baf26287ae6c0...
==========

[commit-bot: I haz the power, 2016-08-24 16:51:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/a6d4645baf26287ae6c0...