scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json - Issue 2270943002: Make Nexus5X bisect bot use 64 bit binaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json

Issue 2270943002: Make Nexus5X bisect bot use 64 bit binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/bisection/android_bisect.py ('k') | scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json

diff --git a/scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json b/scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json

index f9f003c136eb2e56d5d57547383b8a86c827efda..b2cfeac5eb815787bfcc26a0a214a21cf1f86b61 100644

--- a/scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json

+++ b/scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json

@@ -411,7 +411,7 @@

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "OS=android component=static_library fastbuild=1 gomadir='RECIPE_PACKAGE_REPO[build]/goma' target_arch=arm use_goma=1",

+ "GYP_DEFINES": "OS=android component=static_library fastbuild=1 gomadir='RECIPE_PACKAGE_REPO[build]/goma' target_arch=arm64 use_goma=1",

"PATH": "[BUILDER_CACHE]/android_nexus5X_perf_bisect/src/third_party/android_tools/sdk/platform-tools:[BUILDER_CACHE]/android_nexus5X_perf_bisect/src/build/android:%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

"name": "gclient runhooks"

@@ -625,7 +625,7 @@

"cmd": [

"[BUILDER_CACHE]/android_nexus5X_perf_bisect/src/third_party/android_platform/development/scripts/stack",

"--arch",

- "arm",

+ "arm64",

"--more-info",

"[BUILDER_CACHE]/android_nexus5X_perf_bisect/src/out/Release/full_log"