Harmony: disable ripples on Mac

Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state which is defined in the Harmony spec.

BUG=640032
Committed: https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf
Cr-Commit-Position: refs/heads/master@{#414825}

[Elly Fong-Jones, 2016-08-25 21:04:05]

Description was changed from

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them.

TODO: What should we use on Mac? A pressed state like the Shiny Modern controls?

BUG=640032
==========

to

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state
which is defined in the Harmony spec.

BUG=640032
==========

[Elly Fong-Jones, 2016-08-25 21:04:05]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-08-25 21:04:27]

sky: ptal? :)

PlatformStyle is getting to be a bit of a dumping ground of obscurely-named
functions :\

[sky, 2016-08-25 23:44:50]

https://codereview.chromium.org/2270933002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2270933002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/md_text_button.cc:183: UpdateColors();
Are you sure you don't need to call LabelButton::StateChanged() too?

https://codereview.chromium.org/2270933002/diff/40001/ui/views/style/platform...
File ui/views/style/platform_style.h (right):

https://codereview.chromium.org/2270933002/diff/40001/ui/views/style/platform...
ui/views/style/platform_style.h:57: static const bool kUseRipples;
Is there a reason you're going with the more generic ripples instead of a more
specific kUseInkDrop? Are the two ever not the same?

[Elly Fong-Jones, 2016-08-26 15:46:44]

sky: ptal? :)

https://codereview.chromium.org/2270933002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2270933002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/md_text_button.cc:183: UpdateColors();
On 2016/08/25 23:44:50, sky wrote:
> Are you sure you don't need to call LabelButton::StateChanged() too?

Nope, I totally do. Good catch.

https://codereview.chromium.org/2270933002/diff/40001/ui/views/style/platform...
File ui/views/style/platform_style.h (right):

https://codereview.chromium.org/2270933002/diff/40001/ui/views/style/platform...
ui/views/style/platform_style.h:57: static const bool kUseRipples;
On 2016/08/25 23:44:50, sky wrote:
> Is there a reason you're going with the more generic ripples instead of a more
> specific kUseInkDrop? Are the two ever not the same?

In principle, there could be other kinds of ripples later, I guess. The
terminology I used comes from the Harmony specs, which say "ripples are not used
on Mac".

[sky, 2016-08-26 16:33:34]

Ok, LGTM

[Elly Fong-Jones, 2016-08-26 17:02:05]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:56:17]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Elly Fong-Jones, 2016-08-26 19:37:26]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:56:41]

Description was changed from

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state
which is defined in the Harmony spec.

BUG=640032
==========

to

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state
which is defined in the Harmony spec.

BUG=640032
==========

[commit-bot: I haz the power, 2016-08-26 21:56:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 21:58:57]

Description was changed from

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state
which is defined in the Harmony spec.

BUG=640032
==========

to

==========
Harmony: disable ripples on Mac

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state
which is defined in the Harmony spec.

BUG=640032

Committed: https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf
Cr-Commit-Position: refs/heads/master@{#414825}
==========

[commit-bot: I haz the power, 2016-08-26 21:58:59]

Patchset 4 (id:??) landed as
https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf
Cr-Commit-Position: refs/heads/master@{#414825}