Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2270863002: Update log text for glitch info in AudioSyncReader. (Closed)

Created:
4 years, 4 months ago by Henrik Grunell
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, o1ka, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update log text for glitch info in AudioSyncReader. Adds total number of render calls, similar to what's logged in AudioInputSyncWriter. This makes it easier to see the proportion of glitches. Committed: https://crrev.com/aaec8331ac4e822980b2a7da907b68b279630e7a Cr-Commit-Position: refs/heads/master@{#414340}

Patch Set 1 #

Patch Set 2 : Code review. Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Henrik Grunell
As reference, see https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/audio_input_sync_writer.cc?sq=package:chromium&l=110
4 years, 4 months ago (2016-08-23 14:19:16 UTC) #3
DaleCurtis
Just use one of the format macros from https://cs.chromium.org/chromium/src/base/format_macros.h ?
4 years, 4 months ago (2016-08-23 18:45:30 UTC) #4
Henrik Grunell
On 2016/08/23 18:45:30, DaleCurtis wrote: > Just use one of the format macros from > ...
4 years, 4 months ago (2016-08-24 12:03:11 UTC) #5
DaleCurtis
lgtm
4 years, 4 months ago (2016-08-24 17:11:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270863002/20001
4 years, 3 months ago (2016-08-25 06:28:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 06:33:09 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 06:34:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aaec8331ac4e822980b2a7da907b68b279630e7a
Cr-Commit-Position: refs/heads/master@{#414340}

Powered by Google App Engine
This is Rietveld 408576698