third_party/WebKit/Source/core/layout/LayoutTheme.cpp - Issue 2270833002: Fix the crash of issue 2209773002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 2270833002: Fix the crash of issue 2209773002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed another crash. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

index 71d3be274d7037a8aa597f5e5f08199b37fc1d2f..f5df6d8e6fa1458f4d7172e3fa7060128bfc3366 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

@@ -635,7 +635,7 @@ void LayoutTheme::adjustMenuListButtonStyle(ComputedStyle&, Element*) const

void LayoutTheme::adjustSliderContainerStyle(ComputedStyle& style, Element* e) const

{

- if (e->shadowPseudoId() == "-webkit-media-slider-container" || e->shadowPseudoId() == "-webkit-slider-container") {

+ if (e && (e->shadowPseudoId() == "-webkit-media-slider-container" || e->shadowPseudoId() == "-webkit-slider-container")) {

if (style.appearance() == SliderVerticalPart) {

style.setTouchAction(TouchActionPanX);

style.setAppearance(NoControlPart);