|
|
Created:
4 years, 3 months ago by sunyunjia Modified:
4 years, 3 months ago Reviewers:
tkent CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix two crashes caused by crrev.com/413616
BUG=640150, 640494
Committed: https://crrev.com/41928a8e0daf09725e61d36d35905c28e74716d9
Cr-Commit-Position: refs/heads/master@{#414403}
Patch Set 1 #Patch Set 2 : Add a test for the crash #Patch Set 3 : Adds a test. #Patch Set 4 : Fixed another crash. #
Total comments: 2
Patch Set 5 : indent #
Total comments: 1
Patch Set 6 : indentation #
Total comments: 2
Patch Set 7 : Indentation and get .done() function back #Patch Set 8 : Fixing mac issue #Patch Set 9 : indentation #
Messages
Total messages: 54 (38 generated)
Description was changed from ========== Fix the crash in fuzzer BUG=640150 ========== to ========== Fix the crash in fuzzer, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640150 BUG=640150 ==========
The CQ bit was checked by sunyunjia@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sunyunjia@chromium.org changed reviewers: + tkent@chromium.org
Changed a line of code to fix the crash. PTAL, Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
please add a test
Added a test. PTAL, Thanks!
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix the crash in fuzzer, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640150 BUG=640150 ========== to ========== Fix the crash of issue 2209773002 Fix the crash in fuzzer, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640150 Fix the crash in android, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640494 BUG=640150, 640494 ==========
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix the crash of issue 2209773002 Fix the crash in fuzzer, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640150 Fix the crash in android, see link https://bugs.chromium.org/p/chromium/issues/detail?id=640494 BUG=640150, 640494 ========== to ========== Fix two crashes caused by crrev.com/413616 BUG=640150, 640494 ==========
C++ code change looks ok. https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: if (isMac) { Why do you exclude Mac? https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:37: var w = slider.clientWidth; Wrong indentation.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: > if (isMac) { > Why do you exclude Mac? Because Mac doesn't have touch event https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:37: > var w = slider.clientWidth; > Wrong indentation. Done.
lgtm https://codereview.chromium.org/2270833002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:35: var slider = document.getElementById('slider'); Wrong indentation.
The CQ bit was checked by sunyunjia@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2270833002/#ps100001 (title: "indentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/Lay... File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: if (isMac) { indentation is inconsistent with other functions, which apply 2-space indentation. https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:41: chrome.gpuBenchmarking.smoothDrag(x, y, x + w, y, function() {}, touchSourceType); Why did you remove .done() call?
The CQ bit was unchecked by sunyunjia@chromium.org
https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/Lay... > File https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/Lay... > third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:41: > chrome.gpuBenchmarking.smoothDrag(x, y, x + w, y, function() {}, > touchSourceType); > Why did you remove .done() call? Sorry my bad. That was by mistake.
The CQ bit was checked by sunyunjia@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2270833002/#ps120001 (title: "Indentation and get .done() function back")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sunyunjia@chromium.org
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sunyunjia@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2270833002/#ps160001 (title: "indentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Fix two crashes caused by crrev.com/413616 BUG=640150, 640494 ========== to ========== Fix two crashes caused by crrev.com/413616 BUG=640150, 640494 Committed: https://crrev.com/41928a8e0daf09725e61d36d35905c28e74716d9 Cr-Commit-Position: refs/heads/master@{#414403} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/41928a8e0daf09725e61d36d35905c28e74716d9 Cr-Commit-Position: refs/heads/master@{#414403} |