Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2270833002: Fix the crash of issue 2209773002 (Closed)

Created:
4 years, 3 months ago by sunyunjia
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two crashes caused by crrev.com/413616 BUG=640150, 640494 Committed: https://crrev.com/41928a8e0daf09725e61d36d35905c28e74716d9 Cr-Commit-Position: refs/heads/master@{#414403}

Patch Set 1 #

Patch Set 2 : Add a test for the crash #

Patch Set 3 : Adds a test. #

Patch Set 4 : Fixed another crash. #

Total comments: 2

Patch Set 5 : indent #

Total comments: 1

Patch Set 6 : indentation #

Total comments: 2

Patch Set 7 : Indentation and get .done() function back #

Patch Set 8 : Fixing mac issue #

Patch Set 9 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 54 (38 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270833002/1
4 years, 3 months ago (2016-08-23 13:56:47 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-23 13:56:49 UTC) #5
sunyunjia
Changed a line of code to fix the crash. PTAL, Thanks!
4 years, 3 months ago (2016-08-23 14:06:59 UTC) #9
tkent
please add a test
4 years, 3 months ago (2016-08-23 23:02:12 UTC) #12
sunyunjia
Added a test. PTAL, Thanks!
4 years, 3 months ago (2016-08-24 14:23:16 UTC) #13
tkent
C++ code change looks ok. https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html#newcode32 third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: if (isMac) { Why ...
4 years, 3 months ago (2016-08-25 00:43:56 UTC) #22
sunyunjia
https://codereview.chromium.org/2270833002/diff/60001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html#newcode32 > third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: > if (isMac) { > Why do you exclude Mac? Because Mac ...
4 years, 3 months ago (2016-08-25 02:48:53 UTC) #25
tkent
lgtm https://codereview.chromium.org/2270833002/diff/80001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/80001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html#newcode35 third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:35: var slider = document.getElementById('slider'); Wrong indentation.
4 years, 3 months ago (2016-08-25 03:29:52 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270833002/100001
4 years, 3 months ago (2016-08-25 03:39:05 UTC) #29
tkent
https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html File third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html (right): https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html#newcode32 third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:32: if (isMac) { indentation is inconsistent with other functions, ...
4 years, 3 months ago (2016-08-25 03:40:07 UTC) #30
sunyunjia
https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html > File https://codereview.chromium.org/2270833002/diff/100001/third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html#newcode41 > third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input-crash.html:41: > chrome.gpuBenchmarking.smoothDrag(x, y, x + w, y, function() {}, ...
4 years, 3 months ago (2016-08-25 04:37:57 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270833002/120001
4 years, 3 months ago (2016-08-25 04:38:26 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/224566) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-08-25 04:45:39 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270833002/160001
4 years, 3 months ago (2016-08-25 12:11:27 UTC) #51
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-08-25 12:16:33 UTC) #52
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:20:02 UTC) #54
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/41928a8e0daf09725e61d36d35905c28e74716d9
Cr-Commit-Position: refs/heads/master@{#414403}

Powered by Google App Engine
This is Rietveld 408576698