Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 227083007: UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Further clean up condition controlling OptionsView. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index d6f9276fd5953c62641b871cc3b0d903421ce967..199236105e757cf74e911bd10d5c0dddb920cc80 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/profiles/profile_avatar_icon_util.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profile_metrics.h"
#include "chrome/browser/profiles/profile_window.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
@@ -543,8 +544,13 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,
// is indeed shown for the maximum number of times.
browser_->profile()->GetPrefs()->SetInteger(
prefs::kProfileAvatarTutorialShown, kProfileAvatarTutorialShowMax + 1);
+
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_CLOSE_WELCOME_CARD);
ShowView(BUBBLE_VIEW_MODE_PROFILE_CHOOSER, avatar_menu_.get());
} else if (sender == tutorial_enable_new_profile_management_button_) {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_ACCEPT_NEW_PROFILE_MGMT);
profiles::EnableNewProfileManagementPreview();
} else if (sender == remove_account_and_relaunch_button_) {
RemoveAccount();
@@ -619,6 +625,8 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {
} else if (sender == add_account_link_) {
ShowView(BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT, avatar_menu_.get());
} else if (sender == tutorial_learn_more_link_) {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE);
// TODO(guohui): update |learn_more_url| once it is decided.
const GURL lear_more_url("https://support.google.com/chrome/?hl=en#to");
chrome::NavigateParams params(
@@ -688,10 +696,10 @@ views::View* ProfileChooserView::CreateProfileChooserView(
current_profile_view = CreateCurrentProfileView(item, false);
if (view_mode_ == BUBBLE_VIEW_MODE_PROFILE_CHOOSER) {
if (is_new_profile_management) {
- tutorial_view = last_tutorial_mode == TUTORIAL_MODE_SEND_FEEDBACK ?
+ tutorial_view = tutorial_mode_ == TUTORIAL_MODE_SEND_FEEDBACK ?
CreateSendPreviewFeedbackView() :
CreatePreviewEnabledTutorialView(
- item, last_tutorial_mode == TUTORIAL_MODE_PREVIEW_ENABLED);
+ item, tutorial_mode_ == TUTORIAL_MODE_PREVIEW_ENABLED);
} else {
tutorial_view = CreateNewProfileManagementPreviewView();
}
@@ -704,6 +712,12 @@ views::View* ProfileChooserView::CreateProfileChooserView(
}
if (tutorial_view) {
+ // Be sure not to track the tutorial display on View refresh, and only count
+ // the preview-promo view, shown when New Profile Management is off.
+ if (tutorial_mode_ != last_tutorial_mode && !is_new_profile_management) {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO);
+ }
layout->StartRow(1, 0);
layout->AddView(tutorial_view);
}
@@ -733,7 +747,7 @@ views::View* ProfileChooserView::CreateProfileChooserView(
layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
// Option buttons. Only available with the new profile management flag.
- if (switches::IsNewProfileManagement()) {
+ if (option_buttons_view) {
layout->StartRow(0, 0);
layout->AddView(option_buttons_view);
}
@@ -809,7 +823,7 @@ views::View* ProfileChooserView::CreateTutorialView(
title_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
title_label->SetAutoColorReadabilityEnabled(false);
title_label->SetEnabledColor(SK_ColorWHITE);
- title_label ->SetFontList(ui::ResourceBundle::GetSharedInstance().GetFontList(
+ title_label->SetFontList(ui::ResourceBundle::GetSharedInstance().GetFontList(
ui::ResourceBundle::MediumFont));
layout->StartRow(1, 0);
layout->AddView(title_label);
@@ -995,6 +1009,9 @@ views::View* ProfileChooserView::CreateOtherProfilesView(
}
views::View* ProfileChooserView::CreateOptionsView(bool enable_lock) {
+ if (!switches::IsNewProfileManagement())
+ return NULL;
+
views::View* view = new views::View();
views::GridLayout* layout;

Powered by Google App Engine
This is Rietveld 408576698