UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms.

chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c8821d5d22443f03154940f818bfb567a1c16830
--- /dev/null
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
@@ -0,0 +1,129 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/path_service.h"
+#include "base/prefs/pref_service.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profile_metrics.h"
+#include "chrome/browser/profiles/profiles_state.h"
+#include "chrome/browser/ui/browser_dialogs.h"
+#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
+#include "chrome/browser/ui/views/profiles/new_avatar_button.h"
+#include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
+#include "chrome/browser/ui/views/profiles/user_manager_view.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/test_switches.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/uma_histogram_helper.h"
+#include "components/signin/core/common/profile_management_switches.h"
+#include "content/public/test/test_utils.h"
+#include "grit/generated_resources.h"
+#include "ui/views/controls/button/label_button.h"
+
+class ProfileChooserViewBrowserTest : public InProcessBrowserTest {
+ public:
+  ProfileChooserViewBrowserTest();
+  virtual ~ProfileChooserViewBrowserTest();
+
+ protected:
+  virtual void SetUp() OVERRIDE;
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
+  void CreateTestingProfile();
+  void OpenProfileChooserView();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProfileChooserViewBrowserTest);
+};
+
+ProfileChooserViewBrowserTest::ProfileChooserViewBrowserTest() {
+}
+
+ProfileChooserViewBrowserTest::~ProfileChooserViewBrowserTest() {
+}
+
+void ProfileChooserViewBrowserTest::SetUp() {
+  InProcessBrowserTest::SetUp();
+  DCHECK(CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kNewAvatarMenu));
+}
+
+void ProfileChooserViewBrowserTest::SetUpCommandLine(
+    CommandLine* command_line) {
+  command_line->AppendSwitch(switches::kNewAvatarMenu);
+}
+
+void ProfileChooserViewBrowserTest::CreateTestingProfile() {
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  EXPECT_EQ(1u, profile_manager->GetNumberOfProfiles());
+
+  // Sign in the default profile
+  ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
+  cache.SetUserNameOfProfileAtIndex(0, base::UTF8ToUTF16("user_name"));
+
+  base::FilePath path;
+  PathService::Get(chrome::DIR_USER_DATA, &path);
+  path = path.AppendASCII("test_profile");
+  if (!base::PathExists(path))
+    ASSERT_TRUE(base::CreateDirectory(path));
+  Profile* profile =
+      Profile::CreateProfile(path, NULL, Profile::CREATE_MODE_SYNCHRONOUS);
+  profile->GetPrefs()->SetInteger(prefs::kProfileAvatarTutorialShown, 0);
+  profile_manager->RegisterTestingProfile(profile, true, false);
+  EXPECT_EQ(2u, profile_manager->GetNumberOfProfiles());
+}
+
+void ProfileChooserViewBrowserTest::OpenProfileChooserView() {
+  BrowserView* browser_view = reinterpret_cast<BrowserView*>(
+      browser()->window());
+
+  // Ensure that the avatar icon button is not also showing.
+  NewAvatarButton* button = browser_view->frame()->GetNewAvatarMenuButton();
+  ASSERT_TRUE(button);
+
+  ProfileChooserView::clear_close_on_deactivate_for_testing();
+  ui::MouseEvent mouse_ev(ui::ET_MOUSE_RELEASED, gfx::Point(), gfx::Point(), 0,
+                          0);
+  button->NotifyClick(mouse_ev);
+  base::MessageLoop::current()->RunUntilIdle();
+  EXPECT_TRUE(ProfileChooserView::IsShowing());
+}
+
+#if defined(OS_CHROMEOS) || defined(OS_ANDROID) || defined(OS_IOS)
+// This test doesn't make sense for ChromeOS since it has a different
+// multi-profiles menu in the system tray instead.
+//
+// Mobile platforms are also excluded due to a lack of avatar menu.
+#define MAYBE_ViewProfileUMA DISABLED_ViewProfileUMA
+#else
+#define MAYBE_ViewProfileUMA ViewProfileUMA
+#endif
+
+IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, MAYBE_ViewProfileUMA) {

[noms (inactive), 2014/04/29 20:33:48]

This shouldn't be a MAYBE_, if it's not flaky :)

[Mike Lerman, 2014/04/29 20:39:07]

Discuss in person - we'll keep the current structure.

+  UMAHistogramHelper histograms;
+  // If multiprofile mode is not enabled, you can't switch between profiles.
+  if (!profiles::IsMultipleProfilesEnabled())
+    return;
+
+  CreateTestingProfile();
+  ASSERT_NO_FATAL_FAILURE(OpenProfileChooserView());
+
+  histograms.Fetch();
+  histograms.ExpectUniqueSample("Profile.MirrorEnrollment",
+      ProfileMetrics::PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO, 1);
+
+  // If the User Manager hasn't shown yet, wait for it to show up.
+  if (!UserManagerView::IsShowing())

[noms (inactive), 2014/04/29 20:33:48]

You're just showing the bubble, which has nothing to do with the user manager.
So this isn't ever actually going to show up :)

[Mike Lerman, 2014/04/29 20:39:07]

Done.

+    base::MessageLoop::current()->RunUntilIdle();
+
+  // We need to hide the User Manager or else the process can't die.
+  chrome::HideUserManager();
+}