UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms.

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 62 matching lines @@
   };
 
   enum ProfileAuth {
     AUTH_UNNECESSARY,         // Profile was not locked
     AUTH_LOCAL,               // Profile was authenticated locally
     AUTH_ONLINE,              // Profile was authenticated on-line
     AUTH_FAILED,              // Profile failed authentication
     NUM_PROFILE_AUTH_METRICS
   };
 
+  // Enum for tracking whether Mirror is enabled and Promo views.
+  enum ProfileEnrollment {
+    ENROLL_DISPLAY,           // The Mirror Promo was displayed
+    ENROLL_LAUNCH_TUTORIAL,   // The Mirror Promo was displayed

[guohui, 2014/04/25 14:46:50]

it is very confusing to have the same comment for two different enum values.
Please update.

[guohui, 2014/04/25 14:46:50]

launch_tutorial means user clicks the learn more link, right? Please change the
name to somehting like MIRROR_LEARN_MORE. We already use 'tutorial' to mean the
blue tutorial card, it is confusing to reuse the term for the learn more link.

[Mike Lerman, 2014/04/28 14:53:11]

Done.

[Mike Lerman, 2014/04/28 14:53:11]

Done.

+    ENROLL_ACCEPT_MIRROR,     // Mirror was enabled via the Promo
+    ENROLL_CLOSE_PROMO_CARD,  // The Promo was dismissed

[guohui, 2014/04/25 14:46:50]

there are two tutorial cards, it is no clear which one your refer to. The mirror
promo card is not dismiss-able at the moment, please change the name to
something like ENROLL_CLOSE_WELCOME_CARD., and update the comment.

[Mike Lerman, 2014/04/28 14:53:11]

Done.

+    MIRROR_DISABLE,           // Mirror was disabled after having been enabled

[guohui, 2014/04/25 14:46:50]

nit: missing . at the end of the sentence.

[Mike Lerman, 2014/04/28 14:53:11]

Done.

+    NUM_PROFILE_ENROLLMENT_METRICS
+  };
+
   static void UpdateReportedProfilesStatistics(ProfileManager* manager);
 
   static void LogNumberOfProfiles(ProfileManager* manager);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileAuthResult(ProfileAuth metric);
+  static void LogProfileMirrorEnrollment(ProfileEnrollment metric);
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_