UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/pref_service_flags_storage.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/views/profiles/user_manager_view.h"
@@ skipping 495 matching lines @@
     profiles::LockProfile(browser_->profile());
   } else if (sender == add_account_button_) {
     ShowView(BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT, avatar_menu_.get());
   } else if (sender == tutorial_ok_button_) {
     // If the user manually dismissed the tutorial, never show it again by
     // setting the number of times shown to the maximum plus 1, so that later we
     // could distinguish between the dismiss case and the case when the tutorial
     // is indeed shown for the maximum number of times.
     browser_->profile()->GetPrefs()->SetInteger(
         prefs::kProfileAvatarTutorialShown, kProfileAvatarTutorialShowMax + 1);
+
+    ProfileMetrics::LogProfileMirrorEnrollment(ProfileMetrics::PROMO_DISMISS);

[guohui, 2014/04/16 15:47:45]

this dismisses the confirmation tutorial, not the mirror promo tutorial.
Currently mirror promo is not dismiss-able.

[Mike Lerman, 2014/04/24 15:14:16]

Done.

     ShowView(BUBBLE_VIEW_MODE_PROFILE_CHOOSER, avatar_menu_.get());
   } else if (sender == tutorial_enable_new_profile_management_button_) {
     EnableNewProfileManagementPreview();
   } else if (sender == remove_account_and_relaunch_button_) {
     RemoveAccount();
   } else if (sender == account_removal_cancel_button_) {
     account_id_to_remove_.clear();
     ShowView(BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT, avatar_menu_.get());
   } else if (sender == gaia_signin_cancel_button_) {
     std::string primary_account =
@@ skipping 37 matching lines @@
 
   chrome::AttemptRestart();
 }
 
 void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {
   if (sender == manage_accounts_link_) {
     // ShowView() will DCHECK if this view is displayed for non signed-in users.
     ShowView(BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT, avatar_menu_.get());
   } else if (sender == tutorial_learn_more_link_) {
     // TODO(guohui): update |learn_more_url| once it is decided.
+    ProfileMetrics::LogProfileMirrorEnrollment(ProfileMetrics::PROMO_ACCEPT);

[guohui, 2014/04/16 15:47:45]

the link opens the learn more url, it dose not mean user accepts the mirror
promo. Instead you should put the code in EnableNewProfileManagementPreview.

[Mike Lerman, 2014/04/24 15:14:16]

Renamed. Done.

     const GURL lear_more_url("https://support.google.com/chrome/?hl=en#to");
     chrome::NavigateParams params(
         browser_->profile(),
         lear_more_url,
         content::PAGE_TRANSITION_LINK);
     params.disposition = NEW_FOREGROUND_TAB;
     chrome::Navigate(&params);
   } else {
     DCHECK(sender == signin_current_profile_link_);
     ShowView(BUBBLE_VIEW_MODE_GAIA_SIGNIN, avatar_menu_.get());
@@ skipping 59 matching lines @@
       } else {
         current_profile_view = CreateCurrentProfileEditableView(item);
         current_profile_accounts = CreateCurrentProfileAccountsView(item);
       }
     } else {
       other_profiles.push_back(i);
     }
   }
 
   if (tutorial_view) {
+    // Be sure not to track the tutorial display on View refresh.
+    if (tutorial_shown == FALSE)
+      ProfileMetrics::LogProfileMirrorEnrollment(ProfileMetrics::PROMO_DISPLAY);

[guohui, 2014/04/16 15:47:45]

we have two different tutorials at the moment, one that prompts the user to try
out mirror (aka mirror promo), and one that notifies the user that mirror has
been enabled successfully, i don't think you want to mix both. You should only
count the mirror promo tutorial created from
CreateNewProfileManagementPreviewView.

[Mike Lerman, 2014/04/24 15:14:16]

Done.

     layout->StartRow(1, 0);
     layout->AddView(tutorial_view);
   }
 
   if (!current_profile_view) {
     // Guest windows don't have an active profile.
     current_profile_view = CreateGuestProfileView();
     option_buttons_view = CreateOptionsView(false);
   }
 
@@ skipping 508 matching lines @@
       g_browser_process->local_state());
   about_flags::SetExperimentEnabled(
       &flags_storage,
       kNewProfileManagementExperimentInternalName,
       true);
 
   CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kNewProfileManagement);
   chrome::ShowUserManagerWithTutorial(profiles::USER_MANAGER_TUTORIAL_OVERVIEW);
 }