UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms.

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 62 matching lines @@
   };
 
   enum ProfileAuth {
     AUTH_UNNECESSARY,         // Profile was not locked
     AUTH_LOCAL,               // Profile was authenticated locally
     AUTH_ONLINE,              // Profile was authenticated on-line
     AUTH_FAILED,              // Profile failed authentication
     NUM_PROFILE_AUTH_METRICS
   };
 
+  // Enum for tracking whether Mirror is enabled and Promo views.

[Alexei Svitkine (slow), 2014/04/30 16:45:37]

Nit: Mention in comment that this is used in a histogram and entries shouldn't
be removed or re-ordered.

[Mike Lerman, 2014/04/30 18:11:44]

Done.

+  enum ProfileEnrollment {

[msw, 2014/04/29 23:10:52]

nit: should this match the histograms' "ProfileMirrorEnrollment"?

[Mike Lerman, 2014/04/30 18:11:44]

Done.

+    // The Mirror Promo was displayed.

[msw, 2014/04/29 23:10:52]

nit: make these comments more similar with ProfileMirrorEnrollment.

[Mike Lerman, 2014/04/30 18:11:44]

Done.

+    PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO,
+    // The Learn More button was clicked.
+    PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE,
+    // Mirror was enabled via the Promo.
+    PROFILE_ENROLLMENT_ACCEPT_MIRROR,
+    // The Welcome card was dismissed.
+    PROFILE_ENROLLMENT_CLOSE_WELCOME_CARD,
+    // Mirror was disabled after having been enabled.
+    PROFILE_ENROLLMENT_DISABLE_MIRROR,

[msw, 2014/04/29 23:10:52]

nit: this seems fairly distinct from "Webdata DB error" as it's described in
ProfileMirrorEnrollment.

[Mike Lerman, 2014/04/30 18:11:44]

Sorry, I hadn't updated the histograms.xml.
Done.

+    NUM_PROFILE_ENROLLMENT_METRICS,
+  };
+
   static void UpdateReportedProfilesStatistics(ProfileManager* manager);
 
   static void LogNumberOfProfiles(ProfileManager* manager);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileAuthResult(ProfileAuth metric);
+  static void LogProfileMirrorEnrollment(ProfileEnrollment metric);
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_