[Oilpan]: Moving the FontSelector/FontCacheClient, CSSSegmentedFontFace, and FontFaceCache to the o…

Source/core/css/CSSFontFace.h

Index: Source/core/css/CSSFontFace.h
diff --git a/Source/core/css/CSSFontFace.h b/Source/core/css/CSSFontFace.h
index 3fbbe86a9025e102574224c0c7b0cfc305bf14de..39ab613e646e976e2efaf04456ffb6dc12848c38 100644
--- a/Source/core/css/CSSFontFace.h
+++ b/Source/core/css/CSSFontFace.h
@@ -112,6 +112,8 @@ private:
     void setLoadStatus(FontFace::LoadStatus);
 
     UnicodeRangeSet m_ranges;
+    // FIXME: Oilpan: Make m_segmentedFontFace a RawPtrWillBeMember when moving
+    // CSSFontFace to the heap.
     CSSSegmentedFontFace* m_segmentedFontFace;

[haraken, 2014/04/07 14:10:12]

I'm just curious: Is it safe to not replace "a raw pointer from an off-heap
object to an on-heap object" with a Member? I think it's safe as long as the raw
pointer is safe in the current reference-counted world.

[wibling-chromium, 2014/04/08 09:35:59]

Yes, the requirement is that we check whether it should be replaced with a
WeakMember or a Member. In most cases it should just be a member because the
original raw pointer was only there to break a refcount cycle.

     Deque<OwnPtr<CSSFontFaceSource> > m_sources;
     FontFace* m_fontFace;